Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to include metadata when installing with pip/conda #109

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

DarianHole
Copy link
Member

@DarianHole DarianHole commented Aug 23, 2019

Currently, the metadata tables associated with the schemes are not also being included when installing biohansel.

Small change to the setup file to make sure they are copied over with the scheme fasta files

Additional documentation change to the help (-h) statement for Metadata (-M) flag to say which tabular files will work with it (ie .tsv and .tab)

@peterk87
Copy link
Contributor

Hi @DarianHole and @glabbe

How about changing this line (https://github.com/phac-nml/biohansel/blob/development/bio_hansel/metadata.py#L39) to:

dfmd = FILE_EXT_TO_PD_READ_FUNC.get(file_ext, pd.read_table)(path)

to default to reading a metadata file as a tab-delimited table.

What do you think?

@DarianHole
Copy link
Member Author

@peterk87 That seems like a good idea for an improvement. Most of the files that biohansel is working with are tab delimited and it would make it more consistent. We'll see what @glabbe says.

Here, I just noticed (after doing work on my own setup.py file) that the metadata for typhi was not being downloaded when installing it through conda.

@DarianHole DarianHole mentioned this pull request Aug 23, 2019
@glabbe
Copy link
Collaborator

glabbe commented Aug 23, 2019

Sounds good to me @peterk87 and @DarianHole , we can specify to users in the documentation that metadata tables need to be tab-delimited

Copy link
Contributor

@Takadonet Takadonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Takadonet Takadonet merged commit b5c1f5d into development Aug 23, 2019
@peterk87 peterk87 mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants