Make --platform/--interpreter multi-options #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `resolve_multi()` to `pex.resolver` which is simply a wrapper around `pex.resolver.resolve()` for resolving requirements for multiple platforms and/or interpreters. Converted `--platform` and `--interpreter` into multi options. Switched `pex.bin.pex` to use `resolve_multi()` rather than `resolve()`.
- Added docstring to ``resolve_multi()``. - Added defaults for ``interpreters`` and ``platforms`` params if nothing is specified.
kwargs are provided directly to ``resolve_multi()``. ``resolve_multi()`` handles cache_dir conditional via ``resolve()``.
|
looks like this PR failed CI, so no one took a look - but it'd be great to have this feature in master. any thoughts on getting this finalized? if time doesn't permit, you could also offer this up to another contributor to run with as it seems to be mostly there. |
|
Thanks for following up @kwlzn, 'preciate it. I do not have the time to work on this at the moment, and would be happy to hand it off to another contributor. FWIW, I am currently using my resolve_multi branch to generate multi-platform pex files, so hopefully there won't be too much more work. I'm not very familiar with the pex source code, though, so I may be underestimating some of the corner cases. Please let me know if there's anything I can do to help hand off to another contributor. |
Added `resolve_multi()` to `pex.resolver` which is simply a wrapper around `pex.resolver.resolve()` for resolving requirements for multiple platforms and/or interpreters. Converted `--platform` and `--interpreter` into multi options. Switched `pex.bin.pex` to use `resolve_multi()` rather than `resolve()`.
- Added docstring to ``resolve_multi()``. - Added defaults for ``interpreters`` and ``platforms`` params if nothing is specified.
kwargs are provided directly to ``resolve_multi()``. ``resolve_multi()`` handles cache_dir conditional via ``resolve()``.
Added `resolve_multi()` to `pex.resolver` which is simply a wrapper around `pex.resolver.resolve()` for resolving requirements for multiple platforms and/or interpreters. Converted `--platform` and `--interpreter` into multi options. Switched `pex.bin.pex` to use `resolve_multi()` rather than `resolve()`.
- Added docstring to ``resolve_multi()``. - Added defaults for ``interpreters`` and ``platforms`` params if nothing is specified.
kwargs are provided directly to ``resolve_multi()``. ``resolve_multi()`` handles cache_dir conditional via ``resolve()``.
* Document the release process.
…rojects (#275) As per [their blog post of the 27th April](https://blog.readthedocs.com/securing-subdomains/) ‘Securing subdomains’: > Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard. Test Plan: Manually visited all the links I’ve modified.
Setuptools does not require `console_scripts` entry points to call
`sys.exit()` (or similar) to exit non-zero:
The functions you specify are called with no arguments, and their
return value is passed to `sys.exit()`, so you can return an
errorlevel or message to print to stderr
This patch updates pex to follow the same behavior.
Fixes #137.
- Add a new pex.executor.Executor class for normalized subprocess execution. - Add new structured exception types for known failure modes of subprocess execution to provide actionable information to the end users on failure. - Port over all known library usages of subprocess to pex.executor.Executor. - Lightweight manual integration testing with pants master consuming pex master via local whl resolves.
Running bdist_pex would result in the creation of a directory literally named '{pex_root}'.
This fixes it by following behavior similar to that found in pex.bin.pex:main
* Add a test to reveal pants integration breakage. * Repair passing of stdio kwargs to PEX.run().
* Fix bdist_pex --pex-args
Splitting on spaces with break on commands like:
python setup.py bdist_pex \
--pex-args="--python-shebang='#!/usr/bin/env python'"
This uses shlex.split instead.
* Add tests for bdist_pex --pex-args shebang with and without spaces
* Inherit user site with --inherit-path * Extend existing tests for inheriting user site
…292) * Add a test case to reveal an unhandled AttributeError when Executor attempts to execute a dir. * Repair Executor error handling for other classes of IO/OSError.
Added `resolve_multi()` to `pex.resolver` which is simply a wrapper around `pex.resolver.resolve()` for resolving requirements for multiple platforms and/or interpreters. Converted `--platform` and `--interpreter` into multi options. Switched `pex.bin.pex` to use `resolve_multi()` rather than `resolve()`.
- Added docstring to ``resolve_multi()``. - Added defaults for ``interpreters`` and ``platforms`` params if nothing is specified.
kwargs are provided directly to ``resolve_multi()``. ``resolve_multi()`` handles cache_dir conditional via ``resolve()``.
Added `resolve_multi()` to `pex.resolver` which is simply a wrapper around `pex.resolver.resolve()` for resolving requirements for multiple platforms and/or interpreters. Converted `--platform` and `--interpreter` into multi options. Switched `pex.bin.pex` to use `resolve_multi()` rather than `resolve()`.
kwargs are provided directly to ``resolve_multi()``. ``resolve_multi()`` handles cache_dir conditional via ``resolve()``.
Added `resolve_multi()` to `pex.resolver` which is simply a wrapper around `pex.resolver.resolve()` for resolving requirements for multiple platforms and/or interpreters. Converted `--platform` and `--interpreter` into multi options. Switched `pex.bin.pex` to use `resolve_multi()` rather than `resolve()`.
kwargs are provided directly to ``resolve_multi()``. ``resolve_multi()`` handles cache_dir conditional via ``resolve()``.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.