Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdist_pex.run() doesn't resolve cache-dir's "{pex_root"} #274

Closed
weigon opened this issue May 30, 2016 · 1 comment
Closed

bdist_pex.run() doesn't resolve cache-dir's "{pex_root"} #274

weigon opened this issue May 30, 2016 · 1 comment
Assignees
Labels

Comments

@weigon
Copy link

weigon commented May 30, 2016

bdist_pex.run() doesn't rewrite the {pex_root} token as the "pex" cmdline frontend does which leads
to a directory named "{pex_root}/" in the root-folder of the project.

Adding the same rewrite to pex/commands/bdist_pex.run() fixes it:

if options.cache_dir:
  options.cache_dir = make_relative_to_root(options.cache_dir)

Introduced by #206

@kwlzn
Copy link
Contributor

kwlzn commented May 31, 2016

@weigon thanks for the bug report.

@digwanderlust this is related to your --pex-root change - can you take a look?

@kwlzn kwlzn added the bug label May 31, 2016
digwanderlust added a commit to digwanderlust/pex that referenced this issue Jun 8, 2016
* Add unti test to make sure {pex_root} directory is not created
* Update the cache_dir in bdist_pex
@kwlzn kwlzn closed this as completed in 0e1abf7 Jun 9, 2016
@kwlzn kwlzn mentioned this issue Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants