Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open setup.py in binary mode #264

Merged
merged 1 commit into from
May 24, 2016
Merged

Open setup.py in binary mode #264

merged 1 commit into from
May 24, 2016

Conversation

saj
Copy link
Contributor

@saj saj commented May 24, 2016

Fixes #263.

@kwlzn
Copy link
Contributor

kwlzn commented May 24, 2016

mind adding some quick test coverage around this?

it'd be great to prove that your case (./pex27 backoff) and @acaire 's case (./pex34 pygments-markdown-lexer) both work with the binary mode change - and keep it that way going forward.

@kwlzn
Copy link
Contributor

kwlzn commented May 24, 2016

given the active regression, will go ahead and merge this - we can circle back to coverage.

thanks for the bug report and PR.

@kwlzn kwlzn merged commit 0f66dd8 into pex-tool:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants