-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge resolve and resolve_multi #969
Comments
Merged
Additionally it would be good to circle back to the exposed datatypes and exception types and thoroughly document them and check their args as part of this resolve API cleanup and the API formalization umbrelled by #584. |
Since Pex has moved away from suporting any API besides the CLI, this can now be done without all the above prep work needed to support breaking CLI API changes. |
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Aug 23, 2021
Kill ~unused resolve and rename resolve_multi to resolve. Eliminate ResolvedDistribution alias in favor of InstalledDistribution which better reflects the shap of the distribution (not a wheel, but an installed wheel). Fix test-use fallout. Work towards pex-tool#1401. Closes pex-tool#969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These functions are both part of the informal public API. We should deprecate passing a single interpreter and a single platform and just support passing optional lists for each as done in
resolve_multi
. We should also probably pick the name'resolve'
for the merged function, essentially deleting the currentresolve
and replacing it with the currentresolve_multi
renamed toresolve
.Resolving this issue is probably a good time to take up #584 and set up proper deprecation, then removal.
resolve
to supportNone
, singles, or lists forinterpreter
andplatform
and deprecate both callingresolve
with singles and callingresolve_multi
.resolve
and renameresolve_multi
toresolve
.This deprecation should probably use version 3.0.0 as the boundary to conform to Semver.
The text was updated successfully, but these errors were encountered: