Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up resolver internal APIs. #1420

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Aug 23, 2021

Kill ~unused resolve and rename resolve_multi to resolve.
Eliminate ResolvedDistribution alias in favor of InstalledDistribution
which better reflects the shap of the distribution (not a wheel, but an
installed wheel). Fix test-use fallout.

Work towards #1401.
Closes #969

Kill ~unused resolve and rename resolve_multi to resolve.
Eliminate ResolvedDistribution alias in favor of InstalledDistribution
which better reflects the shap of the distribution (not a wheel, but an
installed wheel). Fix test-use fallout.

Work towards pex-tool#1401.
Closes pex-tool#969
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new type hints, looks great

tests/test_resolver.py Show resolved Hide resolved
@jsirois jsirois merged commit 65f7c5e into pex-tool:main Aug 23, 2021
@jsirois jsirois deleted the issues/1401/resolver/cleanup branch September 5, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge resolve and resolve_multi
2 participants