Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document / implement a formal semver release system. #584

Closed
jsirois opened this issue Oct 8, 2018 · 2 comments
Closed

Document / implement a formal semver release system. #584

jsirois opened this issue Oct 8, 2018 · 2 comments
Assignees
@jsirois
Labels
API Issues that relate to changes in the public Pex API bug enhancement release
Milestone
3.0

Comments

@jsirois
Copy link
Member

jsirois commented Oct 8, 2018 •
edited
Loading

We have not held to semver wrt defining the public API or handling deprecations. It may be that only Pants uses PEX via the API, but this is dubious. We should come up with some way for external parties to assess if the API they are using is public so that they can rely on semver for their PEX requirement range.

See: https://semver.org/
This was referenced Oct 8, 2018
Closed
Closed
@jsirois jsirois mentioned this issue Oct 29, 2018
Closed
@jsirois jsirois mentioned this issue May 1, 2019
Merged
@jsirois jsirois mentioned this issue Mar 25, 2020
Merged
@jsirois jsirois mentioned this issue May 11, 2020
Closed
4 tasks
@jsirois jsirois added this to the 3.0 milestone May 11, 2020
@jsirois jsirois added the API Issues that relate to changes in the public Pex API label May 11, 2020
@jsirois jsirois mentioned this issue Oct 10, 2020
Merged
@Eric-Arellano Eric-Arellano mentioned this issue Oct 14, 2020
Merged
Eric-Arellano added a commit that referenced this issue Oct 14, 2020
@Eric-Arellano
Remove --use-first-matching-interpreter misfeature (#1076)
dee8c4f 
This was a misfeature added to support a Pants use case, which is implemented another way.

This never worked very robustly:

> To be clear though, there are many corners this will not work for including mismatching abi (python2.7m vs python2.7mu) when the PEX contains platform specific wheels, etc.

If a user only wants to resolve for one interpreter, they should use `--python` or `--interpreter-constraints` with the upcoming `--python-path` flag.

We don't use a proper deprecation due to #584. We'll call attention to this in the release notes.
@jsirois
Copy link
Member Author

jsirois commented Aug 23, 2021

Although Pants no longer uses any API except the Pex CLI API, the need for semver still exists for CLI changes like adding subcommands 1st class (instead of via the side-door of PEX_TOOLS, etc.).

@jsirois jsirois mentioned this issue Aug 28, 2022
Merged
@jsirois
Copy link
Member Author

jsirois commented Aug 16, 2024

I think the release announcement here has served to close this issue: https://github.com/pex-tool/pex/releases/tag/v2.2.0

It probably also deserves a doc page, but I won't block closing this on that. The doc re-vamp will be quite large and towards the close of this year.

@jsirois jsirois closed this as completed Aug 16, 2024
@jsirois jsirois self-assigned this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
API Issues that relate to changes in the public Pex API bug enhancement release
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@jsirois