Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for OMPL 1.2.0 and above #139

Merged
merged 6 commits into from
Mar 20, 2017
Merged

Support for OMPL 1.2.0 and above #139

merged 6 commits into from
Mar 20, 2017

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Mar 17, 2017 •
edited
Loading

Tested for:

  • Ubuntu 14.04 LTS + OMPL 0.13 (boost smart pointers)
  • Ubuntu 14.04 LTS + OMPL 1.0.0 (boost smart pointers)
  • macOS 10.12 + OMPL 1.3 (STL smart pointers)

Related issue: #132

This change is Reviewable

@jslee02 jslee02 added this to the Aikido 0.0.2 milestone Mar 17, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.288% when pulling 07cff88 on bugfix/ompl_backward_compatibility into 67747e1 on master.

@jslee02 jslee02 mentioned this pull request Mar 17, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.288% when pulling e89b82c on bugfix/ompl_backward_compatibility into 67747e1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.288% when pulling 8f137d2 on bugfix/ompl_backward_compatibility into 67747e1 on master.

mkoval
mkoval approved these changes Mar 18, 2017
View reviewed changes
Copy link
Member

@mkoval mkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice set of changes. Since you bumped the version number to 0.1.2, please tag the commit that is merged into the master accordingly.

include/aikido/planner/ompl/BackwardCompatibility.hpp Outdated
#else
#include <boost/smart_ptr.hpp>
#include <boost/bind.hpp>
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't typically indent the contents of #if blocks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

include/aikido/planner/ompl/BackwardCompatibility.hpp
-> decltype(std::bind(std::forward<F>(f), std::forward<Args>(args)...))
{
return std::bind(std::forward<F>(f), std::forward<Args>(args)...);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is horrifying. Nice work. 😍

@jslee02
Copy link
Member Author

jslee02 commented Mar 19, 2017

Since you bumped the version number to 0.1.2, please tag the commit that is merged into the master accordingly.

I bumped the version to distinguish this branch and master from v0.0.1, which is already released. I think we should add tag v0.0.2 (or greater) when we release the version (we might add more changes for v0.0.2) but not now. Please correct me if I didn't get your point.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.288% when pulling 41a5fbb on bugfix/ompl_backward_compatibility into 3942ff7 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.288% when pulling 41a5fbb on bugfix/ompl_backward_compatibility into 3942ff7 on master.

@jslee02 jslee02 merged commit aced53e into master Mar 20, 2017
@jslee02 jslee02 deleted the bugfix/ompl_backward_compatibility branch March 20, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoval mkoval mkoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aikido 0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jslee02 @coveralls @mkoval