Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMPL Dependency Version #132

Closed
ClintLiddick opened this issue Jan 26, 2017 · 8 comments
Closed

OMPL Dependency Version #132

ClintLiddick opened this issue Jan 26, 2017 · 8 comments
Assignees

Comments

@ClintLiddick
Copy link
Member

While building aikido without catkin there was an error when using the Ubuntu 14.04 packaged OMPL (0.13), but the latest version (1.2.1) installed from source did not work either (many breaking changes, and also requiring a fully c++11 complier and stdlib, so GCC5+ which is not available on 14.04). Installing OMPL 1.1.0 from source worked. I'm not sure the best way to handle this odd dependency situation, but I know we should be able to build outside of a catkin workspace.

@ClintLiddick ClintLiddick changed the title OMPL Dependency OMPL Dependency Version Jan 26, 2017
@mkoval
Copy link
Member

mkoval commented Jan 26, 2017

DART and Aikido both use of C++11 extensively (@mxgrey is a C++ wizard), so I am surprised that you are having issues building with OMPL but not having issues building DART with the same compiler. Are you sure the issues aren't more mundane types of backwards incompatibility?

@PyryM
Copy link

PyryM commented Mar 16, 2017

Was it this issue:

aikido/include/aikido/planner/ompl/GeometricStateSpace.hpp:68:10: error: ‘double aikido::planner::ompl::GeometricStateSpace::getMeasure() const’ marked ‘override’, but does not override
   double getMeasure() const override;
          ^

Because I am having this issue as well. This is on ubuntu 14.04 with gcc 5.4.1 (I installed gcc 5), OMPL from the package manager.

@mkoval
Copy link
Member

mkoval commented Mar 17, 2017

It looks like getMeasure was added in OMPL 1.0.0. The latest version or ros-indigo-ompl is nominally 1.0.3094, which is (I believe) build number 3094 of 1.0.0. Are you using the ROS Debian package for OMPL (i.e. ros-indigo-ompl) or some other build? Can you post the output of dpkg -l | grep ompl?

I don't think this is the same issue that @ClintLiddick had before, but I am not 100% sure.

@PyryM
Copy link

PyryM commented Mar 17, 2017

This is without ROS, so it's just the ubuntu package "ompl", which is apparently 0.13.0. I'll install ompl > 1.0 from source and see if it compiles then; a note in the readme might be worthwhile.

@jslee02
Copy link
Member

jslee02 commented Mar 17, 2017

I also found that OMPL switched from boost smart pointers to STL smart pointers since OMPL 1.2.0. This prevents building Aikido on macOS when the recent version of OMPL is installed (1.3.0).

I think we should either:
(1) support OMPL 0.13.0 (for Ubuntu 14.04 LTS) and above with some bandage code and build scripts for the backward compatibility or
(2) drop supporting old version of OMPL and enforce people to install newer version when they are on Ubuntu 14.04 LTS.

I guess we should (1) since the lab setting is Ubuntu 14.04 LTS.

@cdellin
Copy link

cdellin commented Mar 17, 2017

(Hah reminds me of OR_OMPL_HAS_BOOSTSMARTPTRS)

@aditya-vk
Copy link
Contributor

The tests under tests/planner/ompl fail to build with the latest OMPL version 1.3.0. Support for OMPL 1.2.0 and above set up by @jslee02 fixes most of the issues. (Travis builds with OMPL 1.1.0 and tests build successfully). Opened a branch[WIP] fix/tests_ompl_ver for the same.

@jslee02 jslee02 self-assigned this Jun 12, 2017
@jslee02
Copy link
Member

jslee02 commented Feb 8, 2018

I don't believe this issue is still persistent. Please reopen if it's not.

@jslee02 jslee02 closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants