Make penpal-runtime's TrustedReserves more connfigurable
#3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
added
R0-silent
|
Should coordinate with #3543 and make sure they are compatible |
Ah, looks ok, should not be incompatible, sorry for the noise. |
5 tasks
Fixes the snowbridge test by using the new Penpal config. --------- Co-authored-by: claravanstaden <Cats 4 life!>
claravanstaden
approved these changes
Mar 6, 2024
franciscoaguirre
approved these changes
Mar 6, 2024
svyatonik
approved these changes
Mar 6, 2024
acatangiu
approved these changes
Mar 6, 2024
9 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
bkontur
added a commit
that referenced
this pull request
Mar 8, 2024
The current `penpal` runtime utilizes the `EthereumLocation` parameter, which is employed for XCM emulated integration tests concerning the Rococo <> ETH bridge. It includes a hard-coded chainId for the Ethereum testnet utilized in Rococo. The `EthereumLocation` serves the purpose of aligning with the `TrustedReserves`. However, due to this hard-coded configuration, reusing `penpal` for testing various environments such as Kusama/Polkadot versus Ethereum bridge becomes unfeasible. This PR introduces the capability to easily customize the asset location for `TrustedReserves` without needing to know anything about Ethereum. ## TODO - [x] fix integration tests with `System::set_storage(CustomizableAssetFromSystemAssetHub::key(), <whatever-location-is-needed>)` @claravanstaden - [ ] ~~maybe add some helper function/macro to support `set_storage` for other runtimes (that we could reuse)~~ - [ ] Release patch for: `penpal-runtime` + emulated crate with `set_storage` support (if needed) - [ ] backport to 1.7.0 - [ ] backport to 1.8.0 --------- Co-authored-by: Clara van Staden <[email protected]> # Conflicts: # cumulus/parachains/runtimes/testing/penpal/Cargo.toml
bkontur
added a commit
that referenced
this pull request
Mar 8, 2024
The current `penpal` runtime utilizes the `EthereumLocation` parameter, which is employed for XCM emulated integration tests concerning the Rococo <> ETH bridge. It includes a hard-coded chainId for the Ethereum testnet utilized in Rococo. The `EthereumLocation` serves the purpose of aligning with the `TrustedReserves`. However, due to this hard-coded configuration, reusing `penpal` for testing various environments such as Kusama/Polkadot versus Ethereum bridge becomes unfeasible. This PR introduces the capability to easily customize the asset location for `TrustedReserves` without needing to know anything about Ethereum. ## TODO - [x] fix integration tests with `System::set_storage(CustomizableAssetFromSystemAssetHub::key(), <whatever-location-is-needed>)` @claravanstaden - [ ] ~~maybe add some helper function/macro to support `set_storage` for other runtimes (that we could reuse)~~ - [ ] Release patch for: `penpal-runtime` + emulated crate with `set_storage` support (if needed) - [ ] backport to 1.7.0 - [ ] backport to 1.8.0 --------- Co-authored-by: Clara van Staden <[email protected]> # Conflicts: # cumulus/parachains/runtimes/testing/penpal/Cargo.toml # Conflicts: # Cargo.lock # cumulus/parachains/runtimes/testing/penpal/Cargo.toml
acatangiu
pushed a commit
that referenced
this pull request
Mar 11, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
penpalruntime utilizes theEthereumLocationparameter, which is employed for XCM emulated integration tests concerning the Rococo <> ETH bridge. It includes a hard-coded chainId for the Ethereum testnet utilized in Rococo. TheEthereumLocationserves the purpose of aligning with theTrustedReserves. However, due to this hard-coded configuration, reusingpenpalfor testing various environments such as Kusama/Polkadot versus Ethereum bridge becomes unfeasible.This PR introduces the capability to easily customize the asset location for
TrustedReserveswithout needing to know anything about Ethereum.TODO
System::set_storage(CustomizableAssetFromSystemAssetHub::key(), <whatever-location-is-needed>)@claravanstadenmaybe add some helper function/macro to supportset_storagefor other runtimes (that we could reuse)penpal-runtime+ emulated crate withset_storagesupport (if needed)penpal-runtime'sTrustedReservesmore connfigurable (#3564) (patch for 1.7.0) #3624