Skip to content

Commit

Permalink
Make penpal-runtime's TrustedReserves more connfigurable (#3564)
Browse files Browse the repository at this point in the history
The current `penpal` runtime utilizes the `EthereumLocation` parameter,
which is employed for XCM emulated integration tests concerning the
Rococo <> ETH bridge. It includes a hard-coded chainId for the Ethereum
testnet utilized in Rococo. The `EthereumLocation` serves the purpose of
aligning with the `TrustedReserves`. However, due to this hard-coded
configuration, reusing `penpal` for testing various environments such as
Kusama/Polkadot versus Ethereum bridge becomes unfeasible.

This PR introduces the capability to easily customize the asset location
for `TrustedReserves` without needing to know anything about Ethereum.


## TODO
- [x] fix integration tests with
`System::set_storage(CustomizableAssetFromSystemAssetHub::key(),
<whatever-location-is-needed>)` @claravanstaden
- [ ] ~~maybe add some helper function/macro to support `set_storage`
for other runtimes (that we could reuse)~~
- [ ] Release patch for: `penpal-runtime` + emulated crate with
`set_storage` support (if needed)
  - [ ] backport to 1.7.0
  - [ ] backport to 1.8.0

---------

Co-authored-by: Clara van Staden <[email protected]>
# Conflicts:
#	cumulus/parachains/runtimes/testing/penpal/Cargo.toml

# Conflicts:
#	Cargo.lock
#	cumulus/parachains/runtimes/testing/penpal/Cargo.toml
  • Loading branch information
bkontur committed Mar 8, 2024
1 parent 56bff5f commit 3c646db
Show file tree
Hide file tree
Showing 5 changed files with 878 additions and 1,158 deletions.
Loading

0 comments on commit 3c646db

Please sign in to comment.