-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes snowbridge integration test #3570
Fixes snowbridge integration test #3570
Conversation
@@ -42,6 +42,7 @@ emulated-integration-tests-common = { path = "../../../common", default-features | |||
rococo-westend-system-emulated-network = { path = "../../../networks/rococo-westend-system" } | |||
rococo-system-emulated-network = { path = "../../../networks/rococo-system" } | |||
asset-hub-rococo-runtime = { path = "../../../../../runtimes/assets/asset-hub-rococo", default-features = false } | |||
penpal-runtime = { path = "../../../../../runtimes/testing/penpal", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claravanstaden I would remove this dep here, and just re-export CustomizableAssetFromSystemAssetHub
here: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/integration-tests/emulated/chains/parachains/testing/penpal/src/lib.rs#L18-L20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 4c2ca7b.
@@ -253,6 +254,17 @@ fn send_token_from_ethereum_to_penpal() { | |||
(PenpalASender::get(), INITIAL_FUND), | |||
]); | |||
|
|||
PenpalA::execute_with(|| { | |||
<PenpalA as Chain>::System::set_storage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claravanstaden remove unwrap
and use assert_ok!(
instead please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 4c2ca7b.
The CI pipeline was cancelled due to failure one of the required jobs. |
@@ -42,6 +42,7 @@ emulated-integration-tests-common = { path = "../../../common", default-features | |||
rococo-westend-system-emulated-network = { path = "../../../networks/rococo-westend-system" } | |||
rococo-system-emulated-network = { path = "../../../networks/rococo-system" } | |||
asset-hub-rococo-runtime = { path = "../../../../../runtimes/assets/asset-hub-rococo", default-features = false } | |||
penpal-emulated-chain = { path = "../../../chains/parachains/testing/penpal", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claravanstaden I think no need to add this deps here, because it can be reached from rococo-system-emulated-network
, I will try it in my branch
d3d9a1d
into
paritytech:bko-penpal-customization
Fixes the snowbridge test by using the new Penpal config.