Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(op): L1 receipt rpc methods default trait methods #8437

Merged
merged 131 commits into from
May 31, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented May 28, 2024

Ref #8336

  • Moves L1 transaction receipt RPC methods into default trait methods on trait EthTransactions
  • Introduces new trait EthBlocks, with L1 block receipts RPC logic as default trait methods
  • Introduces new trait BuildReceipt, called from both EthBlocks and EthTransactions, with L1 receipt building as default impl
  • Abstracts data access behind trait method getters, cache and provider, to allow for reusable control flow logic that works for both OP and L1, which is implemented in default trait methods
  • Overrides necessary methods on EthBlocks and BuildReceipt for impl on OptimismApi

rkrasiuk and others added 30 commits May 22, 2024 13:56
Co-authored-by: Alexey Shekhirin <[email protected]>
@emhane
Copy link
Member Author

emhane commented May 29, 2024

love the direction, I think this is exactly what we want.

can merge into scaffolding, or we try it incrementally?

needs to be merged into matt/scaffold-ethapi because atm, it's otherwise broken for op (since code moved out to OptimismApi, but that type isn't plugged in anywhere)

@emhane emhane requested a review from mattsse May 29, 2024 23:45
@emhane emhane changed the base branch from main to matt/scaffold-ethapi May 31, 2024 16:30
@emhane emhane merged commit a737ae0 into matt/scaffold-ethapi May 31, 2024
24 of 31 checks passed
@emhane emhane deleted the emhane/op-eth-get-tx-receipt branch May 31, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation S-blocked This cannot more forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.