-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(op): L1 receipt rpc methods default trait methods #8437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mats with untrusted data (#8345)
Co-authored-by: Emilia Hane <[email protected]>
Co-authored-by: Dan Cline <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Co-authored-by: DaniPopes <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
needs to be merged into matt/scaffold-ethapi because atm, it's otherwise broken for op (since code moved out to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #8336
EthTransactions
EthBlocks
, with L1 block receipts RPC logic as default trait methodsBuildReceipt
, called from bothEthBlocks
andEthTransactions
, with L1 receipt building as default implcache
andprovider
, to allow for reusable control flow logic that works for both OP and L1, which is implemented in default trait methodsEthBlocks
andBuildReceipt
for impl onOptimismApi