Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve HaveNotReceivedUpdatesForAWhile warning #8356

Merged
merged 1 commit into from
May 23, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented May 22, 2024

Fixes #7355

Hopefully this error message inspires more action on the part of the user, so that we get logs sooner rather than later when something actually goes wrong on our side.

@Rjected Rjected added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools labels May 22, 2024
@Rjected Rjected requested review from mattsse and onbjerg as code owners May 22, 2024 21:55
@github-actions github-actions bot added A-consensus Related to the consensus engine C-bug An unexpected or incorrect behavior labels May 22, 2024
@mattsse mattsse merged commit 155876d into main May 23, 2024
30 checks passed
@mattsse mattsse deleted the dan/better-beacon-client-inactive-logs branch May 23, 2024 11:17
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not suggest to "Fix beacon client" after CL inactivity
2 participants