chore: remove network setup from config #8364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
Rjected,
onbjerg,
emhane and
gakonst
as code owners
DaniPopes
approved these changes
May 23, 2024
DaniPopes
reviewed
May 23, 2024
Co-authored-by: DaniPopes <[email protected]>
DaniPopes
approved these changes
May 23, 2024
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
Co-authored-by: DaniPopes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the networkbuilder helper from the config type and instead use the builder API
this removes a few deps from config crate.
needs followup to extract the peersconfig as well.