feat: add activation_block method for Ethereum hardforks
#5723
Conversation
| @@ -51,6 +51,37 @@ pub enum Hardfork { | |||
| Cancun, | |||
| } | |||
|
|
|||
| impl Hardfork { | |||
| /// Returns the activation block number for each Ethereum hardfork. | |||
| pub fn activation_block(&self) -> Option<u64> { | |||
There was a problem hiding this comment.
we can rename this to mainnet_activation_block
but what we want here is activation_block(&self, chain: Chain)
see referenced foundry issue.
I'm fine if fn activation_block only handles Chain::mainnet in this PR
we don't have to fill all blocks for other chains, just to have it so they can be added one by one.
this will mostly be useful for foundry because I intend to use it in anvil eventually
There was a problem hiding this comment.
@mattsse In this case, isn't it better to implement this method for the enum Chain itself by doing activation_block(&self, hardfork: Hardfork)? Because otherwise we have a circular dependency, right? Because the reth-primitives crate itself uses the Hardfork enum. Maybe I'm missing something here.
Also, I wanted to fill in the block activations for certain L2s but do you know where I could have the precise information for each of them? There is no equivalent to the precise Ethereum specification https://ethereum.github.io/execution-specs/autoapi/ethereum/index.html for the other L2s.
There was a problem hiding this comment.
we'd like to migrate to alloy-chains now #5429 which gets rid of the circular dep issue, looks like this is a blocker for this PR
I want this functionality in Hardfork and not chainid, so chain crate stays lean
There was a problem hiding this comment.
@mattsse Please tell me if this is better now.
github-actions
bot
added
the
S-stale
|
cc @mattsse @tcoratger alloy_chains is now merged as of #5952 |
github-actions
bot
removed
the
S-stale
Thanks :) |
Should close #5707.