Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Activation Block Data for Ethereum Hardforks #5707

Closed
DoTheBestToGetTheBest opened this issue Dec 6, 2023 · 5 comments · Fixed by #5723
Closed

Implement Activation Block Data for Ethereum Hardforks #5707

DoTheBestToGetTheBest opened this issue Dec 6, 2023 · 5 comments · Fixed by #5723
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@DoTheBestToGetTheBest
Copy link
Contributor

DoTheBestToGetTheBest commented Dec 6, 2023

Describe the feature

Create a function in the Hardfork enum to return activation block numbers for Ethereum hardforks,

pub fn activation_block(&self) -> Option<u64> {}

Documentation about block number activation : https://ethereum.github.io/execution-specs/autoapi/index.html

Part code : https://github.com/paradigmxyz/reth/blob/main/crates/ethereum-forks/src/hardfork.rs

Additional context

No response

@DoTheBestToGetTheBest DoTheBestToGetTheBest added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 6, 2023
@DoTheBestToGetTheBest
Copy link
Contributor Author

Hey it's possible to add Good First Issue for this one ? :)

@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Dec 10, 2023
@mattsse
Copy link
Collaborator

mattsse commented Dec 10, 2023

related:

foundry-rs/foundry#6440

this function should take Chain as an argument and return the known activation block

@DoTheBestToGetTheBest
Copy link
Contributor Author

DoTheBestToGetTheBest commented Dec 10, 2023

related:

foundry-rs/foundry#6440

this function should take Chain as an argument and return the known activation block

Ty so much for this boss! Hope you're good btw, i hope finishing soon exam and return back here :)

i would like to give this for another person if you are okay :)

Copy link
Contributor

github-actions bot commented Jan 1, 2024

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added S-stale This issue/PR is stale and will close with no further activity and removed S-stale This issue/PR is stale and will close with no further activity labels Jan 1, 2024
@1010adigupta
Copy link
Contributor

1010adigupta commented Jan 4, 2024

Hey @mattsse you can assign me this, ig #5723 aimed to solve this but was unable due to circular dependencies which can be tackled if we switched to alloy-chains instead of current reth-primitive implementation, I am currently working on #5429, hence will see this issue as well simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants