Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alloy_chains::Chain instead of vendoring own implementation #5429

Closed
DaniPopes opened this issue Nov 14, 2023 · 6 comments · Fixed by #5952
Closed

Use alloy_chains::Chain instead of vendoring own implementation #5429

DaniPopes opened this issue Nov 14, 2023 · 6 comments · Fixed by #5952
Assignees
@1010adigupta
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Nov 14, 2023 •
edited
Loading

Describe the feature

Use alloy_chains::Chain instead of vendoring our own implementation in reth_primitives::Chain. Both Chain and NamedChain should be able to be replaced easily.

Additional context

alloy_chains
@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Nov 14, 2023
@1010adigupta
Copy link
Contributor

I would like to take up this issue

@mattsse
Copy link
Collaborator

mattsse commented Nov 14, 2023

assigned

@mattsse mattsse mentioned this issue Dec 6, 2023
Closed
@mattsse mattsse mentioned this issue Dec 18, 2023
Merged
@supernovahs
Copy link
Contributor

I can take this if available

@1010adigupta
Copy link
Contributor

Hey @supernovahs, I have recently started working on it. :)

@1010adigupta
Copy link
Contributor

1010adigupta commented Jan 4, 2024 •
edited
Loading

@mattsse basically instead of reth-primitives::chain_items I need to use alloy-chains::items, wherever they appear and change the associated logic of these items accordingly right?

@1010adigupta 1010adigupta mentioned this issue Jan 4, 2024
Closed
@mattsse
Copy link
Collaborator

mattsse commented Jan 4, 2024

yeah remove reth_primitives::Chain and reexport alloy_chains::Chain instead

@1010adigupta 1010adigupta mentioned this issue Jan 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1010adigupta 1010adigupta

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add alloy_chains
4 participants
@mattsse @DaniPopes @supernovahs @1010adigupta