feat: add scroll as named networks #5702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think we don't want to get into adding chains we cannot run? And the existing non ethereum chains are debt which should be removed? |
|
I had noticed the only mention of Arbitrum was that it had been added to the NamedChain enum, so I thought it would be useful to also include the scroll network(s). Are you suggesting removing the non ethereum chains (L2s) that cannot run like Arbitrum? Please let me know the intended update and I am happy to make the commit. |
mattsse
requested changes
Dec 6, 2023
There was a problem hiding this comment.
we should instead replace all of this with the chains dependency
https://github.com/alloy-rs/chains
ref #5429
onbjerg
changed the title
|
Closing this per the above; feel free to open a PR w the proposed change by @mattsse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.