feat(ci): add rv32im compilation checks #12925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Nov 27, 2024
.github/assets/check_rv32im.sh
Outdated
| # Array of crates to exclude | ||
| # Used with the `contains` function. | ||
| # shellcheck disable=SC2034 | ||
| exclude_crates=( |
There was a problem hiding this comment.
can we invert this please,
checking crates for inclusion is pretty annoying, because what we need to do here now is check that a selection of crates compiles for this target, then we don't need the cargo metadata call
7 tasks
mattsse
approved these changes
Nov 28, 2024
mattsse
requested changes
Nov 28, 2024
.github/assets/check_rv32imac.sh
Outdated
Comment on lines
6
to
10
| reth-evm | ||
| reth-primitives | ||
| reth-primitives-traits | ||
| reth-optimism-forks | ||
| reth-optimism-chainspec |
There was a problem hiding this comment.
this will take a while until we support all of those, can we start with the one that currently succeeds and comment out the others, otherwise this pr will be open for a while
mattsse
approved these changes
Nov 29, 2024
| reth-codecs-derive | ||
| # reth-evm | ||
| # reth-primitives | ||
| # reth-primitives-traits |
There was a problem hiding this comment.
this we should target next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #12891
adds a ci workflow to check that all expected crates are able to compile to the
riscv32imactarget. this is helpful for FPVM / ZK teams to know which crates are safe to import directly from reth.