Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rv32im-unknown-none-elf check to CI #12891

Open
Rjected opened this issue Nov 26, 2024 · 2 comments
Open

Add a rv32im-unknown-none-elf check to CI #12891

Rjected opened this issue Nov 26, 2024 · 2 comments
Labels
A-ci Related to github workflows or other build and lint tools A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request

Comments

@Rjected
Copy link
Member

Rjected commented Nov 26, 2024

Describe the feature

Right now we have a check_wasm script which takes in crates, and checks them for no_std compliance on the wasm target:

cmd="cargo +stable build -p $crate --target wasm32-wasip1 --no-default-features"

We need this script, but with a separate workflow and separate list of crates for the rv32im-unknown-none-elf target. This will allow projects like kona to understand which crates it can use more easily.

Additional context

No response

@Rjected Rjected added A-ci Related to github workflows or other build and lint tools A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request labels Nov 26, 2024
@mattsse
Copy link
Collaborator

mattsse commented Nov 27, 2024

can we also invert the list and only check included crates?

@shekhirin
Copy link
Collaborator

@mattsse the goal was to manually exclude a crate when you create a new one in the project, so that you're aware that your crate isn't no_std-friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Related to github workflows or other build and lint tools A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants