-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add rv32im compilation checks #12925
Merged
+77
−0
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f2d4b3a
add rv32im workflow
zobront b11fc31
loosen requirements to rv32imac
zobront d3b085d
invert to check only listed crates
zobront bd46961
reduce crates to check to current successes
zobront 4f0078f
add back target crates commented out
zobront File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
#!/usr/bin/env bash | ||
set +e # Disable immediate exit on error | ||
|
||
# Array of crates to check | ||
crates_to_check=( | ||
reth-evm | ||
reth-primitives | ||
reth-primitives-traits | ||
reth-optimism-forks | ||
reth-optimism-chainspec | ||
) | ||
|
||
# Array to hold the results | ||
results=() | ||
# Flag to track if any command fails | ||
any_failed=0 | ||
|
||
for crate in "${crates_to_check[@]}"; do | ||
cmd="cargo +stable build -p $crate --target riscv32imac-unknown-none-elf --no-default-features" | ||
|
||
if [ -n "$CI" ]; then | ||
echo "::group::$cmd" | ||
else | ||
printf "\n%s:\n %s\n" "$crate" "$cmd" | ||
fi | ||
|
||
set +e # Disable immediate exit on error | ||
# Run the command and capture the return code | ||
$cmd | ||
ret_code=$? | ||
set -e # Re-enable immediate exit on error | ||
|
||
# Store the result in the dictionary | ||
if [ $ret_code -eq 0 ]; then | ||
results+=("1:✅:$crate") | ||
else | ||
results+=("2:❌:$crate") | ||
any_failed=1 | ||
fi | ||
|
||
if [ -n "$CI" ]; then | ||
echo "::endgroup::" | ||
fi | ||
done | ||
|
||
# Sort the results by status and then by crate name | ||
IFS=$'\n' sorted_results=($(sort <<<"${results[*]}")) | ||
unset IFS | ||
|
||
# Print summary | ||
echo -e "\nSummary of build results:" | ||
for result in "${sorted_results[@]}"; do | ||
status="${result#*:}" | ||
status="${status%%:*}" | ||
crate="${result##*:}" | ||
echo "$status $crate" | ||
done | ||
|
||
# Exit with a non-zero status if any command fails | ||
exit $any_failed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will take a while until we support all of those, can we start with the one that currently succeeds and comment out the others, otherwise this pr will be open for a while