-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log file updates against develop #160
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #160 +/- ##
===========================================
+ Coverage 80.6% 80.85% +0.24%
===========================================
Files 36 36
Lines 2527 2560 +33
Branches 319 320 +1
===========================================
+ Hits 2037 2070 +33
- Misses 386 387 +1
+ Partials 104 103 -1
Continue to review full report at Codecov.
|
* Remove some dependencies that aren't needed * Fixing more dependencies * Updating version number for release * Version 0.5.1 release * Change hard-coded version number (also added #154 to deal with in future) * 100 char limit applied directly to develop
CONTRIBUTING.md
Outdated
- Use a tool such as [yapf](https://github.com/google/yapf) to format your | ||
files; we'd rather spend time developing PANOPTES and not arguing about | ||
style. | ||
- Line length is set at 120 characters instead of 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c/120/100/
CONTRIBUTING.md
Outdated
files; we'd rather spend time developing PANOPTES and not arguing about | ||
style. | ||
- Line length is set at 120 characters instead of 80 | ||
- It is recommended to have your editor auto-format code whenever you save a file rather than attempt to go back and change an entire file all at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply the 100 (or 80? ;-)) limit to the .md files, as long as it still renders correctly.
pocs/utils/logger.py
Outdated
|
||
def _process_str(self, fmt, *args, **kwargs): | ||
log_str = fmt | ||
if len(args) > 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or len(kwargs) > 0
log_fname = '{}-{}-{}'.format(invoked_script, os.getpid(), | ||
datetime.datetime.utcnow().strftime('%Y%m%dT%H%M%SZ')) | ||
log_symlink = '{}/{}.log'.format(log_dir, invoked_script) | ||
|
||
# Alter the log_config to use UTC times | ||
if log_config.get('use_utc', True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we apply use_utc to the file names too? I might like to run my unit with eastern time in the log files, and log file names. I certainly found during debugging the polar alignment issues that it was confusing to add utc in with the other issues.
…OCS into log-file-updates-against-develop
This is the #145 and #152 but applied to the develop branch.
This should follow #159 and will need to be rebased.