Log file updates #163
Log file updates #163
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #163 +/- ##
===========================================
+ Coverage 80.6% 80.82% +0.22%
===========================================
Files 36 36
Lines 2527 2556 +29
Branches 319 320 +1
===========================================
+ Hits 2037 2066 +29
- Misses 386 387 +1
+ Partials 104 103 -1
Continue to review full report at Codecov.
|
| - Use a tool such as [yapf](https://github.com/google/yapf) to format your | ||
| files; we'd rather spend time developing PANOPTES and not arguing about | ||
| style. | ||
| - Line length is set at 120 characters instead of 80 |
There was a problem hiding this comment.
Arg...this and the comment below are the same as what you saw happening with the serial testing PR where it is pulling in the old items.
| example, `my_file.py` instead of `My File.py` | ||
| - Define any project specific terminology or abbreviations you use in the file you use them | ||
| - Variable/function/class and file names should be meaningful and descriptive. | ||
| - File names should be underscored, not contain spaces ex. my_file.py. |
There was a problem hiding this comment.
Please keep the old file names description (lower case, etc.).
|
|
||
| # Configure the logger | ||
| logging.config.dictConfig(log_config) | ||
|
|
||
| # Get the logger and set as attribute to class | ||
| logger = logging.getLogger(profile) | ||
|
|
||
| # Don't want log messages from state machine library |
There was a problem hiding this comment.
I appreciate the comment as I had no idea what this was about. I wonder if this is the kind of thing that could be in conf_files/log.yaml. What do you think?
|
Closing in favor of #165, which is the same thing (with corrections from above) but without the corrupted history. |
Updates to log files.
Replaces #160