100 char limit #159
Merged
100 char limit #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #159 +/- ##
=======================================
Coverage 80.6% 80.6%
=======================================
Files 36 36
Lines 2527 2527
Branches 319 319
=======================================
Hits 2037 2037
Misses 386 386
Partials 104 104
Continue to review full report at Codecov.
|
jamessynge
reviewed
Dec 2, 2017
| @@ -41,7 +41,7 @@ def connect(self): | |||
| self.logger.info('Connected to TheSkyX via {}:{}'.format(self._host, self._port)) | |||
|
|
|||
| def write(self, value): | |||
| assert type(value) is str | |||
| assert isinstance(value, str) | |||
There was a problem hiding this comment.
Ah ha, found the one part of this reformat that wasn't a reformat! ;-)
jamessynge
approved these changes
Dec 2, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 100 char limit applied directly to develop.
The rebase with
1.0-betawas getting ugly so I am essentially re-doing the "features" directly on develop now that we are all agreed to use develop.This will be follow by the fixes to the log file which will be followed by the merging of PACE and PEAS (as separate features)