Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGR: GH50127 fixes error for converting to / creating Index with dtype S3 #51559

Closed
wants to merge 587 commits into from
Closed

REGR: GH50127 fixes error for converting to / creating Index with dtype S3 #51559

wants to merge 587 commits into from

Conversation

Daquisu
Copy link
Contributor

@Daquisu Daquisu commented Feb 22, 2023 •
edited
Loading

@simonjayhawkins simonjayhawkins added Regression Functionality that used to work in a prior pandas version Astype Index Related to the Index class or subclasses labels Feb 22, 2023
@Daquisu Daquisu changed the title BUG: GH50127 fixes error for converting to / creating Index with dtype S3 REGR: GH50127 fixes error for converting to / creating Index with dtype S3 Feb 28, 2023
@Daquisu
Copy link
Contributor Author

Daquisu commented Feb 28, 2023

CI check error seems to be unrelated, since it appears on all latest CIs.

No error other than that, so happy to review it now

@jorisvandenbossche jorisvandenbossche added this to the 2.0 milestone Mar 1, 2023
@MarcoGorelli MarcoGorelli modified the milestones: 2.0, 2.1 Mar 27, 2023
@MarcoGorelli
Copy link
Member

MarcoGorelli commented Mar 27, 2023 •
edited
Loading

moving off the 2.0 milestone as this is a regression from 1.5

EDIT: sorry, this one worked on 1.5. Is it a blocker?

@MarcoGorelli MarcoGorelli modified the milestones: 2.1, 2.0 Mar 27, 2023
jbrockmendel
jbrockmendel reviewed Mar 27, 2023
View reviewed changes
doc/source/whatsnew/v2.0.0.rst Outdated
@@ -1399,6 +1399,7 @@ Other
- Bug in incorrectly accepting dtype strings containing "[pyarrow]" more than once (:issue:`51548`)
- Bug in :meth:`Series.searchsorted` inconsistent behavior when accepting :class:`DataFrame` as parameter ``value`` (:issue:`49620`)
- Bug in :func:`array` failing to raise on :class:`DataFrame` inputs (:issue:`51167`)
- Bug in :class:`Index` when created or converted to the numpy dtype S3 would raise ``NotImplementedError`` (:issue:`50127`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"when created or converted" -> "where creating or converting"?

@datapythonista datapythonista modified the milestones: 2.0, 2.1 Apr 3, 2023
@datapythonista
Copy link
Member

Release day, moving this to the 2.1 milestone.

@datapythonista datapythonista modified the milestones: 2.1, 2.0.1 Apr 3, 2023
@datapythonista
Copy link
Member

Sorry, my bad, the next release should be 2.0.1, changed the milestone again.

@Daquisu
Copy link
Contributor Author

Daquisu commented Apr 22, 2023

Ubuntu / Numpy Dev (pull_request) is failing on all recent PRs, so I guess it is not related to the changes done here.

@datapythonista datapythonista modified the milestones: 2.0.1, 2.0.2 Apr 23, 2023
@datapythonista datapythonista modified the milestones: 2.0.2, 2.0.3 May 26, 2023
rsm-23 and others added 16 commits July 8, 2023 12:28
@rsm-23
DOC: Added to 10mins guide (pandas-dev#54010)
a4154b6 
added basic intro
@jbrockmendel
CLN: is_mixed_type, is_homogeneous_type (pandas-dev#54008)
130471e 
CLN: is_mixed_type
@jbrockmendel
REF: swap axis before calling Manager.pad_or_backfill (pandas-dev#53989)
f217bf9
@rsm-23
DOC: Updated pandas extension list (pandas-dev#53960)
0eb0b0e 
* Updated extension list

* Fixed typo
@Charlie-XIAO
API: add NaTType and NAType to pandas.api.typing (pandas-dev#53958
25249e4 
)

* API: add NaTType and NAType to pandas.api.typing

* updated test
@jbrockmendel
DEPR: downcast keyword in Index.fillna (pandas-dev#53956)
22d21bc 
* DEPR: downcast keyword in Index.fillna

* GH ref

* docstring fixup
@phofl
ENH: Use explicit methods instead of regex pattern in arrow strings (p…
cace5b8 
…andas-dev#54006)

* ENH: Use explicit methods instead of regex pattern in arrow strings

* Fixup

* Fix
@rhshadrach
DEPR: Replacing builtin and NumPy funcs in agg/apply/transform (panda…
817ec46 
…s-dev#53974)

* DEPR: Replacing builtin and NumPy funcs in agg/apply/transform

* mypy fixup
@natmokval
TST: add test to check dtype after replacing values in categorical Se…
b533a22 
…ries inplace (pandas-dev#53993)

* TST: add test to check dtype after replacing categorical Series inplace

* replace tm.assert_index_equal with tm.assert_series_equal
@mroeschke
TST: Mark subprocess tests as single_cpu (pandas-dev#54026)
d6e6aa4
@penelopeysm
DOC: Fix typos in groupby user guide (pandas-dev#54041)
fa19b70 
Fix typos in groupby user guide
@wcgonzal
DOC: add backticks to docstrings (pandas-dev#54030)
c2134a6 
add backticks to docstrings
@mroeschke
CI: Clean GH Action caches weekly (pandas-dev#53753)
43a405b 
* CI: Clean GH Action caches older than 1 week

* purge weekly instead

* ensure we list a lot of caches
@harahu
BUG: Fix failing hash funciton for certain non-ns resolution `Timedel…
689620a 
…ta`s (pandas-dev#54037)

* Add reproducing test

* Attempt fix

* Add GH reference

* Add whatsnew entry

* Pre-commit after the fact
@MilesCranmer
BUG: Fix pandas compatibility with Python installations lacking bzip2…
99fb314 
… headers (pandas-dev#53858)

* BUG: Make bz2 import optional

* CLN: Create `get_bz2_file` to match `get_lzma_file`

* DOC: Add bz2 bugfix to changelog

* TST: Test bz2 non-import works

* TST: Test bz2 non-import from subprocess

* TST: Fix bz2 non-import test

* TST: Fix indentation issues in bz2 import test

* MAINT: Clean up merge commit

* Mark bz2 missing test with `single_cpu`
@Daquisu
Set copy=false after new data array, and adjust texts
b1cbea4
@jbrockmendel
Copy link
Member

this was close to ready, re-opening. @Daquisu can you merge main and address any outstanding comments

@jbrockmendel jbrockmendel reopened this Oct 1, 2023
@mroeschke mroeschke removed this from the 2.0.3 milestone Oct 22, 2023
@jbrockmendel
Copy link
Member

@Daquisu can you merge main and address any outstanding comments? ill make reviewing this a priority

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@attack68 attack68 Awaiting requested review from attack68 attack68 is a code owner

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@Dr-Irv Dr-Irv Awaiting requested review from Dr-Irv Dr-Irv is a code owner

@WillAyd WillAyd Awaiting requested review from WillAyd WillAyd is a code owner

@noatamir noatamir Awaiting requested review from noatamir noatamir is a code owner

@datapythonista datapythonista Awaiting requested review from datapythonista datapythonista is a code owner

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees
No one assigned
Labels
Astype Index Related to the Index class or subclasses Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REGR: Index.astype(<numpy string dtype>) started failing