Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Use explicit methods instead of regex pattern in arrow strings #54006

Merged
merged 3 commits into from
Jul 6, 2023
Merged

ENH: Use explicit methods instead of regex pattern in arrow strings #54006

merged 3 commits into from
Jul 6, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jul 5, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl requested a review from mroeschke July 5, 2023 15:29
@mroeschke mroeschke added Strings String extension data type and string data Arrow pyarrow functionality labels Jul 6, 2023
@phofl
Copy link
Member Author

phofl commented Jul 6, 2023

green now

@mroeschke mroeschke added this to the 2.1 milestone Jul 6, 2023
@mroeschke mroeschke merged commit 431dd6f into pandas-dev:main Jul 6, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the string_implementation branch July 7, 2023 08:04
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@phofl
ENH: Use explicit methods instead of regex pattern in arrow strings (p…
cace5b8 
…andas-dev#54006)

* ENH: Use explicit methods instead of regex pattern in arrow strings

* Fixup

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke