Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: add NaTType and NAType to pandas.api.typing #53958

Merged
merged 3 commits into from
Jul 6, 2023
Merged

API: add NaTType and NAType to pandas.api.typing #53958

merged 3 commits into from
Jul 6, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

@topper-123 topper-123 added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Typing type annotations, mypy/pyright type checking labels Jul 1, 2023
@topper-123 topper-123 added this to the 2.1 milestone Jul 1, 2023
topper-123
topper-123 approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending green.

@mroeschke mroeschke merged commit e997175 into pandas-dev:main Jul 6, 2023
@mroeschke
Copy link
Member

Thanks @Charlie-XIAO

@Dr-Irv Dr-Irv mentioned this pull request Jul 6, 2023
Closed
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@Charlie-XIAO
API: add NaTType and NAType to pandas.api.typing (pandas-dev#53958
25249e4 
)

* API: add NaTType and NAType to pandas.api.typing

* updated test
@Charlie-XIAO Charlie-XIAO deleted the api-typ-add-natp branch September 23, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topper-123 topper-123 topper-123 approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

API: NaTType and NAType are in inconsistent packages
3 participants
@Charlie-XIAO @mroeschke @topper-123