DEPS: drop Python 3.7 and NumPy 1.17 from tests (#41678) #41989

fangchenli · 2021-06-13T22:22:56Z

Most of the new minimum support versions were released between Oct 14, 2019, Python 3.8's initial release date, and June/July 2020.

simonjayhawkins · 2021-06-14T08:43:19Z

Thanks @fangchenli for getting this started. To close the issue, are you planning to update the release notes in this PR too?

fangchenli · 2021-06-14T14:25:43Z

Thanks @fangchenli for getting this started. To close the issue, are you planning to update the release notes in this PR too?

I'll update the doc at last.

fangchenli · 2021-06-14T14:27:06Z

ci/deps/actions-38-minimum_versions.yaml

+  - jinja2=2.11
+  - numba=0.48.0
+  - numexpr=2.7.1
+  - numpy=1.18.5


Conda cannot resolve 1.18.3. so use 1.18.5 instead.

MarcoGorelli · 2021-06-14T15:13:27Z

could update this to --py38-plus

pandas/.pre-commit-config.yaml

Lines 59 to 63 in 0b68d87

    
           -   repo: https://github.com/asottile/pyupgrade 
        
               rev: v2.18.3 
        
               hooks: 
        
               -   id: pyupgrade 
        
                   args: [--py37-plus]

simonjayhawkins · 2021-06-14T15:30:55Z

could update this to --py38-plus

I think maybe code changes should be a follow-on. This PR should probably just be the ci setup and docs.

simonjayhawkins · 2021-06-15T09:41:20Z

update the release notes in this PR too?

I should have said install.rst too.

I think it would be easier for reviewers to see the significant changes, but I also appreciate that while getting things working is an additional burden, so add when ready.

pandas/tests/computation/test_eval.py

fangchenli · 2021-06-15T15:44:04Z

azure-pipelines.yml

@@ -38,7 +38,7 @@ jobs:
        docker pull quay.io/pypa/manylinux2014_i686
        docker run -v $(pwd):/pandas quay.io/pypa/manylinux2014_i686 \
        /bin/bash -xc "cd pandas && \
-        /opt/python/cp37-cp37m/bin/python -m venv ~/virtualenvs/pandas-dev && \
+        /opt/python/cp38-cp38/bin/python -m venv ~/virtualenvs/pandas-dev && \


ABI change in Python 3.8, from cp3xm to cp3x.

simonjayhawkins · 2021-07-02T20:22:56Z

once we do this, we won't be releasing from master until at least 26 December. Historically, we have had 6 monthly releases (except for 0.22, which was a special case for a api breaking change) so shouldn't be an issue. Are we ready for this?

jreback · 2021-07-02T20:42:29Z

once we do this, we won't be releasing from master until at least 26 December. Historically, we have had 6 monthly releases (except for 0.22, which was a special case for a api breaking change) so shouldn't be an issue. Are we ready for this?

yep this is fine this early. going to have a look.

doc/source/whatsnew/v1.4.0.rst

simonjayhawkins · 2021-07-03T11:13:51Z

.github/workflows/posix.yml

          [actions-38.yaml, "not slow and not network and not clipboard", "", "", "", "", ""],
          [actions-38-slow.yaml, "slow", "", "", "", "", ""],
          [actions-38-locale.yaml, "not slow and not network", "language-pack-zh-hans xsel", "zh_CN.utf8", "zh_CN.utf8", "", ""],
-          [actions-38-numpydev.yaml, "not slow and not network", "xsel", "", "", "deprecate", "-W error"],
+          [actions-39-slow.yaml, "slow", "", "", "", "", ""],
+          [actions-39-numpydev.yaml, "not slow and not network", "xsel", "", "", "deprecate", ""],


can you retain the "-W error" in numpydev

Co-authored-by: Simon Hawkins <[email protected]>

jreback

looks fine to me, a couple of comments, ping on green

jreback · 2021-07-04T18:19:10Z

ci/deps/actions-38-db.yaml

@@ -25,11 +25,10 @@ dependencies:
  - flask
  - nomkl
  - numexpr
-  - numpy=1.17.*
+  - numpy=1.18


do we need this as 1.18.*?

I believe 1.18.* and 1.18 are equivalent. They both resolve to the latest 1.18 version.

ci/deps/azure-windows-39.yaml

jreback · 2021-07-04T18:19:57Z

ci/deps/azure-windows-39.yaml

  - openpyxl
-  - pyarrow=0.17.0
+  # - pyarrow


great can you link the issue here

jreback · 2021-07-04T21:30:57Z

https://github.com/pandas-dev/pandas/pull/41989/checks?check_run_id=2984645939 random failure?

fangchenli · 2021-07-04T21:33:05Z

https://github.com/pandas-dev/pandas/pull/41989/checks?check_run_id=2984645939 random failure?

Looks like a flaky test.

jreback · 2021-07-04T21:44:06Z

thanks @fangchenli very nice!

simonjayhawkins · 2021-08-05T10:22:23Z

requirements-dev.txt

 pyarrow>=0.17.0
 python-snappy
-pyqt5>=5.9.2


@fangchenli not needed with py3.7+?

fangchenli added 6 commits June 13, 2021 17:18

DEPS: drop Python 3.7 and NumPy 1.17

a8133dd

update CI

6a265b6

fix version

f33fffc

fix version

e0046e8

fix 32-bit build

b9ddd76

fix 32-bit build

7f1ff20

simonjayhawkins added Dependencies Required and optional dependencies Deprecate Functionality to remove in pandas Compat pandas objects compatability with Numpy or Python functions labels Jun 14, 2021

fangchenli commented Jun 14, 2021

View reviewed changes

fangchenli added 5 commits June 14, 2021 13:00

Merge remote-tracking branch 'upstream/master' into drop-py37

7bdf47c

adjust min version

c4ac216

adjust min versions

de9005b

Merge remote-tracking branch 'upstream/master' into drop-py37

09cd1ac

adjust min versions

8999a92

simonjayhawkins reviewed Jun 15, 2021

View reviewed changes

pandas/tests/computation/test_eval.py Outdated Show resolved Hide resolved

fangchenli added 4 commits June 15, 2021 08:27

Merge remote-tracking branch 'upstream/master' into drop-py37

3865792

add whatsnew note

c29a70b

revert changes in code

c6c8405

revert changes in code

f94dffe

fangchenli changed the title ~~DEPS: drop Python 3.7 and NumPy 1.17 (#41678)~~ DEPS: drop Python 3.7 and NumPy 1.17 from tests (#41678) Jun 15, 2021

fangchenli marked this pull request as ready for review June 15, 2021 15:43

fangchenli commented Jun 15, 2021

View reviewed changes

fangchenli added 2 commits June 15, 2021 11:38

update python version in install.rst

69650cd

revert changes in code

c6798bf

fangchenli added 5 commits June 29, 2021 09:38

pin fsspec

2a41987

Merge remote-tracking branch 'upstream/master' into drop-py37

2638d30

Merge remote-tracking branch 'upstream/master' into drop-py37

4540545

update whatsnew

b5a3e8b

Merge remote-tracking branch 'upstream/master' into drop-py37

62a56b7

simonjayhawkins reviewed Jul 3, 2021

View reviewed changes

doc/source/whatsnew/v1.4.0.rst Outdated Show resolved Hide resolved

simonjayhawkins reviewed Jul 3, 2021

View reviewed changes

fangchenli and others added 2 commits July 3, 2021 08:02

Update doc/source/whatsnew/v1.4.0.rst

eeafda9

Co-authored-by: Simon Hawkins <[email protected]>

add -W error flag back

bd005a2

jreback requested changes Jul 4, 2021

View reviewed changes

fangchenli mentioned this pull request Jul 4, 2021

DEPS: pyarrow support for snappy not built on Windows Python 3.9 #42370

Closed

fangchenli added 2 commits July 4, 2021 13:30

Merge remote-tracking branch 'upstream/master' into drop-py37

47170a4

add comment

c97059f

jreback approved these changes Jul 4, 2021

View reviewed changes

jreback merged commit 83f2583 into pandas-dev:master Jul 4, 2021

This was referenced Jul 4, 2021

CLN: remove Python 3.8 compat #42374

Merged

CLN: remove np17 compat #42375

Merged

fangchenli deleted the drop-py37 branch July 7, 2021 02:40

simonjayhawkins reviewed Aug 5, 2021

View reviewed changes

requirements-dev.txt

pyarrow>=0.17.0

python-snappy

pyqt5>=5.9.2

Copy link

Member

simonjayhawkins Aug 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fangchenli not needed with py3.7+?

weiji14 mentioned this pull request Aug 10, 2021

NEP29: Set minimum required version to NumPy 1.18+ GenericMappingTools/pygmt#1430

Merged

5 tasks

fangchenli mentioned this pull request Aug 27, 2021

DEPS: Bump minimum Numba version #43257

Closed

hugovk mentioned this pull request Aug 28, 2021

Dropping Python 2.7 support wesm/pandas2#5

Closed

jakirkham mentioned this pull request Oct 20, 2022

Update Python version to latest googlecolab/colabtools#2165

Closed

This was referenced Apr 4, 2023

Unpin sqlalchemy once issue is fixed huggingface/datasets#5477

Closed

Unpins sqlAlchemy huggingface/datasets#5595

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPS: drop Python 3.7 and NumPy 1.17 from tests (#41678) #41989

DEPS: drop Python 3.7 and NumPy 1.17 from tests (#41678) #41989

fangchenli commented Jun 13, 2021 •

edited by jreback

Loading

simonjayhawkins commented Jun 14, 2021

fangchenli commented Jun 14, 2021 •

edited

Loading

fangchenli Jun 14, 2021

MarcoGorelli commented Jun 14, 2021

simonjayhawkins commented Jun 14, 2021

simonjayhawkins commented Jun 15, 2021

fangchenli Jun 15, 2021

simonjayhawkins commented Jul 2, 2021

jreback commented Jul 2, 2021

simonjayhawkins Jul 3, 2021

jreback left a comment

jreback Jul 4, 2021

fangchenli Jul 4, 2021

jreback Jul 4, 2021

jreback commented Jul 4, 2021

fangchenli commented Jul 4, 2021

jreback commented Jul 4, 2021

simonjayhawkins Aug 5, 2021

DEPS: drop Python 3.7 and NumPy 1.17 from tests (#41678) #41989

DEPS: drop Python 3.7 and NumPy 1.17 from tests (#41678) #41989

Conversation

fangchenli commented Jun 13, 2021 • edited by jreback Loading

simonjayhawkins commented Jun 14, 2021

fangchenli commented Jun 14, 2021 • edited Loading

fangchenli Jun 14, 2021

Choose a reason for hiding this comment

MarcoGorelli commented Jun 14, 2021

simonjayhawkins commented Jun 14, 2021

simonjayhawkins commented Jun 15, 2021

fangchenli Jun 15, 2021

Choose a reason for hiding this comment

simonjayhawkins commented Jul 2, 2021

jreback commented Jul 2, 2021

simonjayhawkins Jul 3, 2021

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

jreback Jul 4, 2021

Choose a reason for hiding this comment

fangchenli Jul 4, 2021

Choose a reason for hiding this comment

jreback Jul 4, 2021

Choose a reason for hiding this comment

jreback commented Jul 4, 2021

fangchenli commented Jul 4, 2021

jreback commented Jul 4, 2021

simonjayhawkins Aug 5, 2021

Choose a reason for hiding this comment

fangchenli commented Jun 13, 2021 •

edited by jreback

Loading

fangchenli commented Jun 14, 2021 •

edited

Loading