NEP29: Set minimum required version to NumPy 1.18+ #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following NEP29 policy. Bumps minimum supported NumPy version to 1.18 in the setup.py, requirements.txt and environment.yml files. Also update installation documentation and set CI tests to run on NumPy 1.18.
|
Following the discussions in #1074, I think we should add the dev version to the "compatibility table" in the README file, right? |
Also link to v0.5.0 milestone and development documentation page.
weiji14
force-pushed
the
nep29/drop-numpy1.17
branch
from
1febbb3 to
d1d359b
Compare
seisman
reviewed
Aug 10, 2021
maxrjones
reviewed
Aug 10, 2021
Co-Authored-By: Meghan Jones <[email protected]>
seisman
approved these changes
Aug 11, 2021
|
Merge this in directly or wait 24hours? Note that I'll also need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require |
|
I think it's OK to merge now. |
|
Cool, branch protection settings have been updated to use
|
This was referenced Dec 19, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ls#1430) Following NEP29 policy. Bumps minimum supported NumPy version to 1.18 in the setup.py, requirements.txt and environment.yml files. Also update installation documentation and set CI tests to run on NumPy 1.18. * List NumPy >= 1.18 in compatibility table on main README.rst * Mention dev docs directly in compatibility table Co-authored-by: Meghan Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Following NEP29 policy where NumPy 1.17 is to be dropped on or after 26 July 2021 (in a minor version increment, i.e. for PyGMT v0.5.0). Bumps minimum supported NumPy version to 1.18 in the setup.py, requirements.txt and environment.yml files. Also update installation documentation and set CI tests to run on NumPy 1.18.
This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.4.1/maintenance.html#dependencies-policy, xref #1074.
Around the PyData ecosystem, it looks like
pandas1.4 (pandas-dev/pandas#41989) andgeopandas0.10.0 (geopandas/geopandas#1877) will be using Numpy 1.18+ too.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version