Replace pkg_resources with importlib.metadata #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address #1672 If I understood it correctly this PR should not be merged before we drop Python 3.7 suppoort next week on Dec. 26, 2021.
Yes, do you want to open two PRs dropping supports of old Python and NumPy versions.
|
weiji14
reviewed
Dec 20, 2021
seisman
reviewed
Dec 20, 2021
Damn missed that. Thanks @seisman. Co-authored-by: TIAN Dongdong <[email protected]>
seisman
reviewed
Dec 20, 2021
Co-authored-by: TIAN Dongdong <[email protected]>
seisman
approved these changes
Dec 20, 2021
seisman
added
the
final review call
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Use `importlib.metadata` from the standard library (added in Python 3.8) to retrieve the package version at runtime. A bit faster than using the `pkg_resources` which adds some overhead and sets a runtime dependency on `setuptools`. * rename version variables in __init__.py Co-authored-by: TIAN Dongdong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Address #1672
If I understood it correctly this PR should not be merged before we drop Python 3.7 suppoort next week on Dec. 26, 2021.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version