Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpins sqlAlchemy #5595

Closed
wants to merge 3 commits into from
Closed

Conversation

lazarust
Copy link

@lazarust lazarust commented Mar 1, 2023

Closes #5477

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@mariosasko
Copy link
Collaborator

It looks like this issue hasn't been fixed yet, so let's wait a bit more.

@albertvillanova
Copy link
Member

albertvillanova commented Apr 4, 2023

@lazarust thanks for your work, but unfortunately we cannot merge it.

See my comment in: #5477 (comment)

The fix was released yesterday (2023-04-03) only in pandas-2.0.0:

but it will not be back-ported to pandas-1:

Also note that pandas-2.0.0 dropped support for Python 3.7:

Therefore, we cannot unpin sqlalchemy until we drop support for Python 3.7 (these Python users cannot use pandas-2). See our latest CI checks below:

  • "CI / test" fails because it runs on Python 3.7
  • "CI / test_py310" succeeds because it runs on Python 3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin sqlalchemy once issue is fixed
4 participants