-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mix EA into DTA/TDA; part of 24024 #24502
Conversation
lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #24502 +/- ##
===========================================
- Coverage 92.31% 43.05% -49.27%
===========================================
Files 166 166
Lines 52391 52400 +9
===========================================
- Hits 48363 22559 -25804
- Misses 4028 29841 +25813
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24502 +/- ##
==========================================
+ Coverage 92.31% 92.31% +<.01%
==========================================
Files 166 166
Lines 52391 52400 +9
==========================================
+ Hits 48363 48372 +9
Misses 4028 4028
Continue to review full report at Codecov.
|
ping |
thanks |
…strings * upstream/master: TST: Skip db tests unless explicitly specified in -m pattern (pandas-dev#24492) Mix EA into DTA/TDA; part of 24024 (pandas-dev#24502) DOC: Fix building of a single API document (pandas-dev#24506) DOC: Fixing broken references in the docs (pandas-dev#24497) DOC: Splitting api.rst in several files (pandas-dev#24462) Fix misdescription in escapechar (pandas-dev#24490) Floor and ceil methods during pandas.eval which are provided by numexpr (pandas-dev#24355) BUG: Pandas any() returning false with true values present (GH pandas-dev#23070) (pandas-dev#24434) Misc separable pieces of pandas-dev#24024 (pandas-dev#24488) use capsys.readouterr() as named tuple (pandas-dev#24489) REF/TST: replace capture_stderr with pytest capsys fixture (pandas-dev#24496) TST- Fixing issue with test_parquet test unexpectedly passing (pandas-dev#24480) DOC: Doc build for a single doc made much faster, and clean up (pandas-dev#24428) BUG: Fix+test timezone-preservation in DTA.repeat (pandas-dev#24483) Implement reductions from pandas-dev#24024 (pandas-dev#24484)
* upstream/master: REF/TST: replace capture_stdout with pytest capsys fixture (pandas-dev#24501) BUG: fix .iat assignment creates a new column (pandas-dev#24495) DOC: add checks on the returns section in the docstrings (pandas-dev#23138) (pandas-dev#23432) ENH: Add strings_as_fixed_length parameter for df.to_records() (pandas-dev#18146) (pandas-dev#22229) TST: Skip db tests unless explicitly specified in -m pattern (pandas-dev#24492) Mix EA into DTA/TDA; part of 24024 (pandas-dev#24502) DOC: Fix building of a single API document (pandas-dev#24506)
This is nearly all of the remaining DTA/TDA changes in #24024. The things that are not included:
value_counts
from 24024 has small change to make sure the tz-aware case is correct regardless of how the constructor changes in 24024 get resolved. A test is added specifically to check for this.The changes implied by mixing ExtensionArray into DatetimeLikeArrayMixin are not tested yet, won't be until the extension tests part of #24024 is merged. I don't see any way around that except for doing 24024 all at once.