Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF/TST: replace capture_stdout with pytest capsys fixture #24501

Merged
merged 3 commits into from
Dec 30, 2018

Conversation

simonjayhawkins
Copy link
Member

follow-on from #24496

@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #24501 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24501      +/-   ##
==========================================
- Coverage    92.3%    92.3%   -0.01%     
==========================================
  Files         166      166              
  Lines       52412    52405       -7     
==========================================
- Hits        48381    48374       -7     
  Misses       4031     4031
Flag Coverage Δ
#multiple 90.73% <ø> (-0.01%) ⬇️
#single 43.04% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 87.68% <ø> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681e75c...cc5726f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #24501 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24501      +/-   ##
==========================================
- Coverage   92.31%    92.3%   -0.01%     
==========================================
  Files         166      166              
  Lines       52391    52384       -7     
==========================================
- Hits        48363    48355       -8     
- Misses       4028     4029       +1
Flag Coverage Δ
#multiple 90.73% <ø> (-0.01%) ⬇️
#single 43.04% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 87.6% <ø> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9267e27...cfdf3be. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Dec 30, 2018

can you merge master

@jreback jreback added the Testing pandas testing functions or related to the test suite label Dec 30, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 30, 2018
@jreback
Copy link
Contributor

jreback commented Dec 30, 2018

ping on green.

@simonjayhawkins
Copy link
Member Author

@jreback green!

@jreback jreback merged commit 100ffff into pandas-dev:master Dec 30, 2018
@jreback
Copy link
Contributor

jreback commented Dec 30, 2018

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the capture_stdout branch December 30, 2018 22:56
thoo added a commit to thoo/pandas that referenced this pull request Dec 30, 2018
* upstream/master:
  REF/TST: replace capture_stdout with pytest capsys fixture (pandas-dev#24501)
  BUG: fix .iat assignment creates a new column (pandas-dev#24495)
  DOC: add checks on the returns section in the docstrings (pandas-dev#23138) (pandas-dev#23432)
  ENH: Add strings_as_fixed_length parameter for df.to_records() (pandas-dev#18146) (pandas-dev#22229)
  TST: Skip db tests unless explicitly specified in -m pattern (pandas-dev#24492)
  Mix EA into DTA/TDA; part of 24024 (pandas-dev#24502)
  DOC: Fix building of a single API document (pandas-dev#24506)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants