Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF/TST: remove patch from testing.py #24515

Merged
merged 2 commits into from
Dec 31, 2018
Merged

REF/TST: remove patch from testing.py #24515

merged 2 commits into from
Dec 31, 2018

Conversation

simonjayhawkins
Copy link
Member

logical follow-on from #24501

replace use of patch from testing.py with pytest builtin fixture monkeypatch

jreback
jreback requested changes Dec 31, 2018
View reviewed changes
pandas/tests/io/test_packers.py
import glob
import os
from warnings import catch_warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u remove this file from setup.cfg (as u have i sorted it)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24515 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24515      +/-   ##
==========================================
+ Coverage   31.88%   31.88%   +<.01%     
==========================================
  Files         166      166              
  Lines       52434    52425       -9     
==========================================
- Hits        16718    16717       -1     
+ Misses      35716    35708       -8
Flag Coverage Δ
#multiple 30.29% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 37.59% <ø> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449d665...70b0b58. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24515 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24515      +/-   ##
==========================================
+ Coverage   31.88%   31.88%   +<.01%     
==========================================
  Files         166      166              
  Lines       52434    52425       -9     
==========================================
- Hits        16718    16717       -1     
+ Misses      35716    35708       -8
Flag Coverage Δ
#multiple 30.29% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 37.59% <ø> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449d665...70b0b58. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 31, 2018 •
edited
Loading

Codecov Report

Merging #24515 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24515      +/-   ##
==========================================
+ Coverage   31.88%   31.88%   +<.01%     
==========================================
  Files         166      166              
  Lines       52434    52425       -9     
==========================================
- Hits        16718    16717       -1     
+ Misses      35716    35708       -8
Flag Coverage Δ
#multiple 30.29% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 37.59% <ø> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449d665...eba1280. Read the comment docs.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Clean labels Dec 31, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 31, 2018
@jreback jreback merged commit d89b2a6 into pandas-dev:master Dec 31, 2018
@jreback
Copy link
Contributor

jreback commented Dec 31, 2018

thanks!

if you happen to isort things, and its on the list can edit setup.cfg in the future (also PR's to finish that up ok too!)

@simonjayhawkins simonjayhawkins deleted the patch branch January 1, 2019 21:01
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
REF/TST: remove patch from testing.py (pandas-dev#24515)
6d9298e
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
REF/TST: remove patch from testing.py (pandas-dev#24515)
5bd6323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jreback @gfyoung