Implement reductions from #24024 #24484

jbrockmendel · 2018-12-29T16:39:10Z

min/max signatures+docstrings are changed from #24024, instead match those of DatetimeIndexOpsMixin (with appropriate docstring edits)

The min/max implementations are unchanged from 24024. In an upcoming pass I'll see if we can pawn any more of it off to nanops.

Tests are verbatim from 24024.

jreback

maybe out th treats in the new pandas/tests/reductions

jreback · 2018-12-29T16:42:27Z

pandas/core/arrays/datetimelike.py

+        Index.max : Return the maximum value in an Index.
+        Series.max : Return the maximum value in a Series.
+        """
+        # TODO: skipna is broken with max.


this was just fixed?

I thought so too, but no. I expect it won't be too tough to fix nanops to apply the DTI fix to DTA, will do so in an upcoming pass after the 24024-specific parts are de-duplicated

jreback · 2018-12-29T16:43:02Z

pandas/tests/arrays/test_datetimes.py

+
+class TestReductions(object):
+
+    @pytest.mark.parametrize("tz", [None, "US/Central"])


in test_reductions?

before long, yah. For now i want to make rebasing 24024 easy on tom

jreback · 2018-12-29T16:58:56Z

ping on green.

codecov · 2018-12-29T18:47:08Z

Codecov Report

Merging #24484 into master will increase coverage by <.01%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master   #24484      +/-   ##
==========================================
+ Coverage    92.3%   92.31%   +<.01%     
==========================================
  Files         166      166              
  Lines       52386    52412      +26     
==========================================
+ Hits        48357    48382      +25     
- Misses       4029     4030       +1

Flag	Coverage Δ
#multiple	`90.73% <96.15%> (ø)`	⬆️
#single	`43.05% <15.38%> (-0.02%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/arrays/datetimelike.py	`95.5% <96.15%> (+0.03%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b2b18...bf99607. Read the comment docs.

codecov · 2018-12-29T18:47:08Z

Codecov Report

Merging #24484 into master will decrease coverage by 49.27%.
The diff coverage is 15.38%.

@@             Coverage Diff             @@
##           master   #24484       +/-   ##
===========================================
- Coverage   92.31%   43.03%   -49.28%     
===========================================
  Files         166      166               
  Lines       52335    52361       +26     
===========================================
- Hits        48313    22535    -25778     
- Misses       4022    29826    +25804

Flag	Coverage Δ
#multiple	`?`
#single	`43.03% <15.38%> (-0.02%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/arrays/datetimelike.py	`44.6% <15.38%> (-51.06%)`	⬇️
pandas/io/formats/latex.py	`0% <0%> (-100%)`	⬇️
pandas/core/categorical.py	`0% <0%> (-100%)`	⬇️
pandas/io/sas/sas_constants.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/plotting.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/converter.py	`0% <0%> (-100%)`	⬇️
pandas/io/formats/html.py	`0% <0%> (-98.65%)`	⬇️
pandas/core/groupby/categorical.py	`0% <0%> (-95.46%)`	⬇️
pandas/io/sas/sas7bdat.py	`0% <0%> (-91.17%)`	⬇️
pandas/io/sas/sas_xport.py	`0% <0%> (-90.15%)`	⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeff38d...244d37b. Read the comment docs.

jbrockmendel · 2018-12-29T18:47:47Z

this will need rebase following #24476.

jbrockmendel · 2018-12-29T21:33:10Z

Ping

jreback · 2018-12-29T21:57:11Z

pandas/core/arrays/datetimelike.py

+
+    def min(self, axis=None, skipna=True, *args, **kwargs):
+        """
+        Return the minimum value of the Array or minimum along


are these meant in inherit docstrings? these should have Parameters if not

these are copied from the DatetimeIndexOps versions, with "Index" changes to "Array" and Index.min/Index.max added to the See Also sections. These will be templated/shared before long hopefully

ok can u make a follow up issue for this

* upstream/master: BUG: Fix+test timezone-preservation in DTA.repeat (pandas-dev#24483) Implement reductions from pandas-dev#24024 (pandas-dev#24484)

* upstream/master: DOC: Fixing broken references in the docs (pandas-dev#24497) DOC: Splitting api.rst in several files (pandas-dev#24462) Fix misdescription in escapechar (pandas-dev#24490) Floor and ceil methods during pandas.eval which are provided by numexpr (pandas-dev#24355) BUG: Pandas any() returning false with true values present (GH pandas-dev#23070) (pandas-dev#24434) Misc separable pieces of pandas-dev#24024 (pandas-dev#24488) use capsys.readouterr() as named tuple (pandas-dev#24489) REF/TST: replace capture_stderr with pytest capsys fixture (pandas-dev#24496) TST- Fixing issue with test_parquet test unexpectedly passing (pandas-dev#24480) DOC: Doc build for a single doc made much faster, and clean up (pandas-dev#24428) BUG: Fix+test timezone-preservation in DTA.repeat (pandas-dev#24483) Implement reductions from pandas-dev#24024 (pandas-dev#24484)

…strings * upstream/master: TST: Skip db tests unless explicitly specified in -m pattern (pandas-dev#24492) Mix EA into DTA/TDA; part of 24024 (pandas-dev#24502) DOC: Fix building of a single API document (pandas-dev#24506) DOC: Fixing broken references in the docs (pandas-dev#24497) DOC: Splitting api.rst in several files (pandas-dev#24462) Fix misdescription in escapechar (pandas-dev#24490) Floor and ceil methods during pandas.eval which are provided by numexpr (pandas-dev#24355) BUG: Pandas any() returning false with true values present (GH pandas-dev#23070) (pandas-dev#24434) Misc separable pieces of pandas-dev#24024 (pandas-dev#24488) use capsys.readouterr() as named tuple (pandas-dev#24489) REF/TST: replace capture_stderr with pytest capsys fixture (pandas-dev#24496) TST- Fixing issue with test_parquet test unexpectedly passing (pandas-dev#24480) DOC: Doc build for a single doc made much faster, and clean up (pandas-dev#24428) BUG: Fix+test timezone-preservation in DTA.repeat (pandas-dev#24483) Implement reductions from pandas-dev#24024 (pandas-dev#24484)

reductions from 24024

a1bdb34

jreback requested changes Dec 29, 2018

View reviewed changes

Merge branch 'master' of https://github.com/pandas-dev/pandas into eared

45761d5

jreback added Datetime Datetime data dtype API Design labels Dec 29, 2018

jreback added this to the 0.24.0 milestone Dec 29, 2018

jreback approved these changes Dec 29, 2018

View reviewed changes

jbrockmendel added 2 commits December 29, 2018 09:29

Merge branch 'master' of https://github.com/pandas-dev/pandas into eared

e3fb0ef

fix _reduce

244d37b

jbrockmendel added 2 commits December 29, 2018 11:24

isort fixup

56bcc80

Merge branch 'master' of https://github.com/pandas-dev/pandas into eared

bf99607

jreback requested changes Dec 29, 2018

View reviewed changes

jreback merged commit 02a97c0 into pandas-dev:master Dec 29, 2018

jbrockmendel deleted the eared branch December 29, 2018 22:10

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Implement reductions from pandas-dev#24024 (pandas-dev#24484)

c710e5a

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Implement reductions from pandas-dev#24024 (pandas-dev#24484)

f56966a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement reductions from #24024 #24484

Implement reductions from #24024 #24484

jbrockmendel commented Dec 29, 2018

jreback left a comment

jreback Dec 29, 2018

jbrockmendel Dec 29, 2018

jreback Dec 29, 2018

jbrockmendel Dec 29, 2018

jreback commented Dec 29, 2018

codecov bot commented Dec 29, 2018 •

edited

Loading

codecov bot commented Dec 29, 2018

jbrockmendel commented Dec 29, 2018

jbrockmendel commented Dec 29, 2018

jreback Dec 29, 2018

jbrockmendel Dec 29, 2018

jreback Dec 29, 2018


		class TestReductions(object):

		@pytest.mark.parametrize("tz", [None, "US/Central"])

Implement reductions from #24024 #24484

Implement reductions from #24024 #24484

Conversation

jbrockmendel commented Dec 29, 2018

jreback left a comment

Choose a reason for hiding this comment

jreback Dec 29, 2018

Choose a reason for hiding this comment

jbrockmendel Dec 29, 2018

Choose a reason for hiding this comment

jreback Dec 29, 2018

Choose a reason for hiding this comment

jbrockmendel Dec 29, 2018

Choose a reason for hiding this comment

jreback commented Dec 29, 2018

codecov bot commented Dec 29, 2018 • edited Loading

Codecov Report

codecov bot commented Dec 29, 2018

Codecov Report

jbrockmendel commented Dec 29, 2018

jbrockmendel commented Dec 29, 2018

jreback Dec 29, 2018

Choose a reason for hiding this comment

jbrockmendel Dec 29, 2018

Choose a reason for hiding this comment

jreback Dec 29, 2018

Choose a reason for hiding this comment

codecov bot commented Dec 29, 2018 •

edited

Loading