fix(linter/react_perf): allow new objects, array, fns, etc in top scope

[DonIsaac]

Consider the following code:

import { FC } from 'react'
import { SvgIcon } from '@mui/material'

const StyledIcon = <SvgIcon sx={{ padding: 1, color: '#ff0000' }} />
//          reported violation  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
export const MyComponent: FC = () => {
    return (
        <div>
            {StyledIcon}
            {/* ... */}
        </div>
    )
}

This should not be a violation since the JSX is pre-computed and re-used, which
does not break React's Object.is() checks.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[DonIsaac]

• feat(linter/react-perf): handle new objects and arrays in prop assignment patterns #4396
• fix(linter/react_perf): allow new objects, array, fns, etc in top scope #4395 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4395 will not alter performance

_{Comparing don/07-21-fix_linter/react_perf_allow_new_objects_array_fns_etc_in_top_scope (ac08de8) with main (00c7b7d)}

Summary

✅ 32 untouched benchmarks

[graphite-app]

Merge activity

• Jul 22, 9:38 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 22, 9:38 PM EDT: mysteryven added this pull request to the Graphite merge queue.
• Jul 22, 9:44 PM EDT: mysteryven merged this pull request with the Graphite merge queue.