fix(codegen): object shorthand with parens ({x: (x)}) -> ({ x }) (#…

…4391)
oxc-project · Jul 21, 2024 · 44a10c4 · 44a10c4
1 parent e70c67b
commit 44a10c4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/crates/oxc_codegen/examples/codegen.rs b/crates/oxc_codegen/examples/codegen.rs
@@ -57,7 +57,7 @@ fn main() -> std::io::Result<()> {
         }
         let printed = CodeGenerator::new()
             .enable_comment(
-                &source_text,
+                &printed,
                 ret.trivias.clone(),
                 CommentOptions { preserve_annotate_comments: true },
             )

diff --git a/crates/oxc_codegen/src/gen.rs b/crates/oxc_codegen/src/gen.rs
@@ -1554,7 +1554,7 @@ impl<'a, const MINIFY: bool> Gen<MINIFY> for ObjectProperty<'a> {
 
         let mut shorthand = false;
         if let PropertyKey::StaticIdentifier(key) = &self.key {
-            if let Expression::Identifier(ident) = &self.value {
+            if let Expression::Identifier(ident) = self.value.without_parenthesized() {
                 if key.name == p.get_identifier_reference_name(ident) {
                     shorthand = true;
                 }

diff --git a/crates/oxc_codegen/tests/integration/unit.rs b/crates/oxc_codegen/tests/integration/unit.rs
@@ -130,6 +130,7 @@ fn for_stmt() {
 fn shorthand() {
     test("let _ = { x }", "let _ = {x};\n");
     test("let { x } = y", "let { x } = y;\n");
+    test("({ x: (x) })", "({x});\n");
     test("({ x } = y)", "({x} = y);\n");
 }