perf(linter): no_shadow_restricted_names only look up name in hashmap once

[overlookmotel]

eslint(no_shadow_restricted_names) lint rule emits a diagnostic for every declaration of a symbol with a restricted name.

Currently for a var which has redeclarations, the var name is looked up in hash map of restricted names repeatedly for each redeclaration. This PR changes that to only do a single hashmap lookup.

Also, do the hashmap lookup first, as the vast majority of symbols will not be restricted names, so function can exit ASAP in that common case without also doing string comparison to undefined.

[overlookmotel]

• perf(semantic)!: remove SymbolTable::spans field #4473
• perf(linter): no_shadow_restricted_names only look up name in hashmap once #4472 👈
• refactor(semantic): methods take Span as param, not &Span #4470
• perf(semantic): give AstNodeId a niche #4469
• refactor(syntax): give ScopeId a niche #4468
• refactor(syntax): use NonMaxU32 for IDs #4467
• fix(syntax): fix unsound use of NonZeroU32 #4466
• perf(linter): avoid unnecessary work in nextjs:no_duplicate_head rule #4465
• perf(semantic): remove span field from Reference #4464
• perf(semantic): reduce storage size for symbol redeclarations #4463
• refactor(semantic): populate declarations field in SymbolTable::create_symbol #4461
• fix(transformer): add to SymbolTable::declarations for all symbols #4460
• refactor(semantic): re-order SymbolTable fields #4459
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #4472 will create unknown performance changes

_{Comparing 07-25-perf_linter_no_shadow_restricted_names_only_look_up_name_in_hashmap_once (b60bdf1) with main (81384f5)}

Summary

🆕 32 new benchmarks

Benchmarks breakdown

	Benchmark	main	07-25-perf_linter_no_shadow_restricted_names_only_look_up_name_in_hashmap_once	Change
🆕	codegen[checker.ts]	N/A	18.4 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	75.1 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	378 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	22.7 µs	N/A
🆕	lexer[antd.js]	N/A	20.1 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5 ms	N/A
🆕	lexer[checker.ts]	N/A	12 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.2 ms	N/A
🆕	linter[cal.com.tsx]	N/A	768.7 ms	N/A
🆕	linter[checker.ts]	N/A	1.3 s	N/A
🆕	minifier[antd.js]	N/A	281.6 ms	N/A
🆕	minifier[react.development.js]	N/A	3.2 ms	N/A
🆕	minifier[typescript.js]	N/A	511.7 ms	N/A
🆕	prepass[antd.js]	N/A	15.8 ms	N/A
🆕	prepass[react.development.js]	N/A	207.6 µs	N/A
🆕	prepass[typescript.js]	N/A	27.9 ms	N/A
🆕	parser[RadixUIAdoptionSection.jsx]	N/A	77.2 µs	N/A
🆕	parser[antd.js]	N/A	103.5 ms	N/A
🆕	parser[cal.com.tsx]	N/A	24 ms	N/A
🆕	parser[checker.ts]	N/A	52.4 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[graphite-app]

Merge activity

• Jul 25, 8:12 PM EDT: Boshen added this pull request to the Graphite merge queue.
• Jul 25, 8:53 PM EDT: Boshen merged this pull request with the Graphite merge queue.