perf(semantic): reduce overhead of cfg recording ast nodes

[overlookmotel]

Control flow graph builder records AST node IDs in a temp structure ast_nodes_records. Only the first AST node ID inserted into the Vec is ever used, so turn it into just a single value.

Using AstNodeId::dummy() as sentinel for "not set" instead of using Option<AstNodeId> to reduce size of the records stack. Option<AstNodeId> is 16 bytes.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• perf(semantic): reduce AstNodeId to u32 #4264
• perf(semantic): do not record ast nodes for cfg if cfg disabled #4263
• perf(semantic): reduce overhead of cfg recording ast nodes #4262 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4262 will not alter performance

_{Comparing 07-15-perf_semantic_reduce_overhead_of_cfg_recording_ast_nodes (da69076) with main (a8dc4f3)}

Summary

✅ 32 untouched benchmarks

[rzvxa]

Nice, I wanted to make this change for a long time, I'm glad you went ahead and refactored this.😍

[graphite-app]

Merge activity

• Jul 15, 12:42 AM EDT: Boshen merged this pull request with the Graphite merge queue.