refactor(semantic): alter syntax of control_flow! macro

[overlookmotel]

Previously:

let ix = control_flow!(|self, cfg| cfg.current_node_ix);

after this PR:

let ix = control_flow!(self, |cfg| cfg.current_node_ix);

It expands to:

let ix = if let Some(ref mut cfg) = self.cfg {
    cfg.current_node_ix
} else {
    Default::default()
};

So rationale for this change is that it makes it clearer that self is passed in and cfg comes out into the "closure".

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• refactor(semantic): alter syntax of control_flow! macro #4275 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4275 will not alter performance

_{Comparing 07-15-refactor_semantic_alter_syntax_of_control_flow_macro (25f0771) with main (639fd48)}

Summary

✅ 32 untouched benchmarks

[overlookmotel]

@rzvxa Out of interest, why if let Some(ref mut cfg) = self.cfg rather than if let Some(cfg) = &mut self.cfg? Is there a subtle difference between the two?

[rzvxa]

@rzvxa Out of interest, why if let Some(ref mut cfg) = self.cfg rather than if let Some(cfg) = &mut self.cfg? Is there a subtle difference between the two?

Not a functional one, I find this too noisy(lots of symbols).

if let Some($cfg) = &mut $self.cfg {
    $body
} else {
}

So I prefer ref $thing over &$thing in macros.

[graphite-app]

Merge activity

• Jul 15, 10:30 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 15, 10:30 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
• Jul 15, 10:35 AM EDT: overlookmotel merged this pull request with the Graphite merge queue.

[overlookmotel]

Thanks for satisfying my curiosity!