Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(semantic): reduce overhead of cfg recording ast nodes #4262

Merged
merged 1 commit into from
Jul 15, 2024
Merged

perf(semantic): reduce overhead of cfg recording ast nodes #4262

merged 1 commit into from
Jul 15, 2024

Commits on Jul 15, 2024

  1. perf(semantic): reduce overhead of cfg recording ast nodes (#4262) 

    Control flow graph builder records AST node IDs in a temp structure `ast_nodes_records`. Only the first AST node ID inserted into the `Vec` is ever used, so turn it into just a single value.

Using `AstNodeId::dummy()` as sentinel for "not set" instead of using `Option<AstNodeId>` to reduce size of the records stack. `Option<AstNodeId>` is 16 bytes.
    @overlookmotel
    overlookmotel committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    da69076 View commit details
    Browse the repository at this point in the history