refactor: move code parts from files app to web-pkg or web-client #9731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
changed the title
5 tasks
JammingBen
force-pushed
the
refactor-from-files-app-to-web-pkg
branch
from
23e4e33 to
44c1c71
Compare
dschmidt
approved these changes
Sep 27, 2023
JammingBen
force-pushed
the
refactor-from-files-app-to-web-pkg
branch
from
9de1bb6 to
4487ea2
Compare
…avigation.vue with slot
Importing and using this helper with jest.mock() can cause problems when the mocked method is exported via a index.ts file, hence removing it.
JammingBen
force-pushed
the
refactor-from-files-app-to-web-pkg
branch
from
55f0060 to
52b15d7
Compare
dschmidt
approved these changes
Sep 27, 2023
|
SonarCloud Quality Gate failed.
|
delete-merged-branch
bot
deleted the
refactor-from-files-app-to-web-pkg
branch
|
🎉 |
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
) * Backup app, dependencies migration to web-pkg * remove FilesViewWrapper.vue, repurposed useScrollTo, replaced SharesNavigation.vue with slot * removed import of FileViewWrapper * replacing useScrollTo from web-app-files for web-pkg * removed useResourceViewDefault dependency with useSelectedResources, backup app * removing unnecessary files from web-pkg, migrating tests to web-pkg * removing copied dependencies from web-app-files, fixing imports * fix stuff after rebase * remove backup app as it was only needed temporarily * clean up lock file * fix scrollTo composable events * create web-client helper for shares * fix unit tests * add missing scrollToResourceFromRoute param * test: remove test helper createMockActionComposables Importing and using this helper with jest.mock() can cause problems when the mocked method is exported via a index.ts file, hence removing it. * fix remaining issues after rebasing * pass fullShareOwnerPaths property to aggregateResourceShares --------- Co-authored-by: Jacob Noah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Successor of #9602 (I couldn't push the rebased branch to the fork for some reasons, hence creating a new PR. Big thanks to @jacob-nv for doing most of the heavy lifting - I'm just fixing some small leftover issues).
Moved code parts:
web-pkg)web-pkg)AppBarSidebarToggleContextActionsResourceTableweb-pkg)useResourceRouteResolveruseScrollTouseSelectedResourcesuseActiveLocation(toweb-pkg)web-pkg)web-pkg)web-pkg)buildShare...methods (toweb-client)Related Issue
Types of changes