refactor: consistenly use webdav abstraction layer #9728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
use-webdav-abstraction
branch
from
b095b55 to
5dc09e8
Compare
dschmidt
reviewed
Sep 27, 2023
| return clientService.owncloudSdk.fileTrash | ||
| .clearTrashBin(path) | ||
| return clientService.webdav | ||
| .clearTrashBin(space, { hasShareJail: unref(hasShareJail), user: store.getters.user }) |
There was a problem hiding this comment.
Should we pass this in via parameter here or should we set it globally for the clientService?
There was a problem hiding this comment.
Yes, good idea! I think we need that anyway in the future when we're removing the SDK. Will do in a follow-up.
packages/web-app-files/src/composables/actions/spaces/useSpaceActionsUploadImage.ts
Show resolved
Hide resolved
JammingBen
force-pushed
the
use-webdav-abstraction
branch
from
5dc09e8 to
c492c11
Compare
JammingBen
force-pushed
the
use-webdav-abstraction
branch
from
c492c11 to
f07f687
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dschmidt
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes it easier to remove the SDK in the future.
Related Issue
Types of changes