feat: full share owner paths #9721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
reviewed
Sep 21, 2023
packages/web-app-files/tests/unit/components/FilesList/ResourceTable.spec.ts
Outdated
Show resolved
Hide resolved
dschmidt
reviewed
Sep 21, 2023
packages/web-app-files/tests/unit/components/AppBar/CreateAndUpload.spec.ts
Outdated
Show resolved
Hide resolved
JammingBen
commented
Sep 22, 2023
packages/web-app-files/src/components/FilesList/ResourceTable.vue
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
mindblowing-share-urls-2
branch
from
59863ee to
9917008
Compare
|
SonarCloud Quality Gate failed.
|
5 tasks
dschmidt
approved these changes
Sep 27, 2023
5 tasks
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Add routing options to ocis.web.config.json * wip: implement full share owner paths * wip: fix breadcrumb and ancestor loading * fixup! wip: fix breadcrumb and ancestor loading * fixup! fixup! wip: fix breadcrumb and ancestor loading * wip: fix external app handling * Make unit tests work for now * Remove console.log * fix project space access detection * style: run linter * add isOwner method for spaces * introduce useBreadcrumbsFromPath composable * adjust share root item name * wip: fix active route item * Fix logic to determine active sidebar nav items * fix active share nav item * prevent mountpoint loading in personal space * Fix unit tests * Fix unit tests * Fix unit tests * pass spaces to triggerShareAction helper * move comopsable usage out of method * undo temp config * fix space matching when idBased is disabled * fix trashbin overview * fix trashbin overview tests --------- Co-authored-by: Dominik Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Successor of #9221
Introduces a new config option
routing.fullShareOwnerPaths. When enabling this flag, incoming shares will be accessed via the share owner's space instead of a virtual share space. This also reveals full resource paths to share recipients, even if they don't have access to all parent resources.Note: There has not been a decision whether this feature should be productized or not, hence the PR is missing a changelog item, proper documentation and tests (for now).
Related Issue
Types of changes
To-Do
isAccessibleResourcethereisOwnermethod to spacesFollow-ups
fullShareOwnerPathsoption? Docs? Config in ocis? @tbsbdrfullShareOwnerPathsis disabled