Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backups App #9267

Closed
tbsbdr opened this issue Jun 16, 2023 · 8 comments
Closed

Backups App #9267

tbsbdr opened this issue Jun 16, 2023 · 8 comments

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 16, 2023

  • relates to: 2714602
  • enable to run the app as extension
  • provide an option to reuse components
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jun 19, 2023

@elizavetaRa could you provide a pointer where we can experience what the app does?

@kulmann
Copy link
Member

kulmann commented Jun 19, 2023

We discussed in a call that ownCloud will not implement the Backups app, but will provide component reusability as needed. @labkode @diocas @elizavetaRa please confirm.

@elizavetaRa @diocas please provide a full list of components and composables from the files app that are needed in a more generic way (= web-pkg).

@labkode
Copy link

labkode commented Jun 23, 2023

Hi @kulman,

The list of components are available as imports in the following commit:
cernbox@2714602

@pascalwengerter
Copy link
Contributor

Hi @kulman,

The list of components are available as imports in the following commit: cernbox@2714602

Just want to point out that this goes beyond the scope of "just four components imported" since

  • it imports helpers, composables and more (search for 'web-app-files/ within packages/web-app-backups/src/components/BackupsSection.vue
  • AppBar and ResourceTable both use further helpers/composables/components from the files app and interact with the store, which needs to be taken into consideration when estimating the complexity behind an extraction.

Not saying it's not possible though, I suppose an extension system would actually greatly benefit from having these available

@labkode
Copy link

labkode commented Jun 23, 2023

@pascalwengerter in case it helps: owncloud/core#17610

@pascalwengerter
Copy link
Contributor

@pascalwengerter in case it helps: owncloud/core#17610

Are you sure the link you provided is the right one? It doesn't fit to how the current project is set up or a modern approach to JS. What we will have to do to resolve #8281 (and thereby this issue) is to extract the used functionality into e.g. the web-pkg submodule and therefore make it available to extension developers

@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
@JammingBen
Copy link
Contributor

@jacob-nv CERN has some existing code for a backup app that can be found here: 2714602. The one issue: the main component BackupsSection contains a few imports & usages from web-app-files, which is a no-go. Therefore the plan is to remove that dependency from the app.

I'd suggest you start by creating a PR in our repo that implements the very same code (= create packages/web-app-backups). Then iterate over the imports from web-app-files and move this code to web-pkg (when it makes sense) so the app can make use of it.

The next iteration would be to move the app from our repo to https://github.com/cernbox/web-extensions.

@JammingBen
Copy link
Contributor

Implemented via cernbox/web-extensions#21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants