Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup App #9591

Closed
wants to merge 3 commits into from
Closed

Backup App #9591

wants to merge 3 commits into from

Conversation

jacob-nv
Copy link
Contributor

Description

Moved back up app, moved all the dependencies from web-app-files.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 17, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen
Copy link
Contributor

I believe there was a missunderstanding 🙈 The plan was not to to re-implement the files app in the backup app, but to move certain code paths from the files-app to web-pkg. When looking at the original code from the backup app, these imports are affected:

  • import ResourceTable from 'web-app-files/src/components/FilesList/ResourceTable.vue'
  • import { useResourcesViewDefaults } from 'web-app-files/src/composables'
  • import AppBar from 'web-app-files/src/components/AppBar/AppBar.vue'
  • import { CreateTargetRouteOptions } from 'web-app-files/src/helpers/folderLink'
  • import { buildWebDavFilesPath } from 'web-app-files/src/helpers/resources'
  • import { createLocationSpaces } from 'web-app-files/src/router'

Of course these components/composables/helpers use a few things from the files-app as well, which also need to be transferred to web-pkg.

The goal is to have this stuff centralized in web-pkg so other apps like the files app or the backup app can use it.

@dschmidt
Copy link
Member

I believe there was a missunderstanding 🙈 The plan was not to to re-implement the files app in the backup app, but to move certain code paths from the files-app to web-pkg. When looking at the original code from the backup app, these imports are affected:

  • import ResourceTable from 'web-app-files/src/components/FilesList/ResourceTable.vue'
  • import { useResourcesViewDefaults } from 'web-app-files/src/composables'
  • import AppBar from 'web-app-files/src/components/AppBar/AppBar.vue'
  • import { CreateTargetRouteOptions } from 'web-app-files/src/helpers/folderLink'
  • import { buildWebDavFilesPath } from 'web-app-files/src/helpers/resources'
  • import { createLocationSpaces } from 'web-app-files/src/router'

Of course these components/composables/helpers use a few things from the files-app as well, which also need to be transferred to web-pkg.

The goal is to have this stuff centralized in web-pkg so other apps like the files app or the backup app can use it.

Exactly, but try to be reasonable - it needs to make sense to move things to web-pkg, sometimes it might be required to decouple things a bit e.g. by using the eventBus. Unfortunately there's no definitive rule, other than "it shohld make sense"

@jacob-nv
Copy link
Contributor Author

Moved to #9602

@jacob-nv jacob-nv closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backups App
3 participants