Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusage of web components in extensions limited #8281

Closed
Tracked by #7930
elizavetaRa opened this issue Jan 19, 2023 · 8 comments
Closed
Tracked by #7930

Reusage of web components in extensions limited #8281

elizavetaRa opened this issue Jan 19, 2023 · 8 comments

Comments

@elizavetaRa
Copy link
Member

Background:
Developing feature rich extensions like backups extension that lists backup resources similar to web-app-files

Issue:
A lot of components from web-app-files are needed for the extension: ResourceTable, AppBar, breadcrumbs, useSort, useResourcesViewDefaults etc.
According to @dschmidt reusage of components from web can only be done from web-pkg and web-client. Moving all of these components would require also moving of their imported components, almost the whole web-app-files.

Keeping the extension inside of the web is long term also a bad solution as changes in imports would cause a lot of effort in maintainability

@dschmidt
Copy link
Member

As responded later to you in chat (when you probably already called it a day) we need to hear more explicit use cases and what exactly you want to achieve.

If you give us more details about what exactly you want to achieve, we can help laying out an architecture.

@pascalwengerter
Copy link
Contributor

@kulmann from a cursory read it seemed like there has been basically a re-implementation of the ResourceTable for spaces in the admin-app recently, moving ResourceTable (and potentially ResourceTiles also 😇 ) to the web-pkg could both resolve that, force the project to move away from some mixins/web-app-files-internal APIs towards more open ones and address parts of this ticket?

@elizavetaRa
Copy link
Member Author

@dschmidt We want to be able to reuse things from web-app-files in external extensions. The extensions should be able to import from a certain web version and don't break when there are modifications of reused components.

Example: backups extension that has a logic, similar to web-app-files: reuses ResourceTable, breadcrumbs, actions, useResourcesViewDefaults etc. but it's reachable from ApplicationSwitcher and has own endpoints and loadResourcesTasks.
Screenshot from 2023-01-25 11-16-04

As I understand, the only way would be to move needed components to web-pkg, but this is a large part of web-app-files as components have their own imports from web-app-files. For now, we keep the extension internally in our web fork, but on upstream rebases it breaks and needs fixes.

@tbsbdr tbsbdr changed the title Reusage of web components in extensions hardly limited Reusage of web components in extensions limited Jun 1, 2023
@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 1, 2023

hardly limited = not limited ;-)
changed title

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 12, 2023

realtes to: 2714602

@kulmann
Copy link
Member

kulmann commented Jun 19, 2023

Please provide a list of components and composables (as complete as possible) which you would like to use from the files app @elizavetaRa

@kulmann
Copy link
Member

kulmann commented Jun 20, 2023

@elizavetaRa @diocas can we close this issue as superseded by #9267 ? 🤔 or do you have requirements for component reusability in other cases as well?

@diocas diocas closed this as completed Jun 20, 2023
@diocas
Copy link
Contributor

diocas commented Jun 20, 2023

ping @elizavetaRa
Please re-open if there are more requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants