-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test-only] e2e.Delete creating link to space step #9025
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, I don't get it: That means creating public links for spaces is no longer possible?! Because the UI currently doesn't reflect that. |
Yes, public link for project space disabled. owncloud/ocis#6278 (comment) This PR will return e2e to ocis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to get the pipeline running, but we might need to re-add the steps later again. I think it was a misunderstanding and creating links for project spaces should still be possible in the future.
Yes, sure. When or if we are able to create a link I will return deleted tests |
owncloud/ocis#6271
owncloud/ocis#6278
Sharing of project space root via public link does no longer work -> I changed test to enable e2e tests again