Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] e2e.Delete creating link to space step #9025

Merged
merged 3 commits into from
May 12, 2023

Conversation

ScharfViktor
Copy link
Contributor

owncloud/ocis#6271
owncloud/ocis#6278

Sharing of project space root via public link does no longer work -> I changed test to enable e2e tests again

@update-docs
Copy link

update-docs bot commented May 11, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor changed the title Delete creating link to project space [test-only] e2e.Delete creating link to space step May 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JammingBen
Copy link
Contributor

Sorry, I don't get it: That means creating public links for spaces is no longer possible?! Because the UI currently doesn't reflect that.

@ScharfViktor
Copy link
Contributor Author

Sorry, I don't get it: That means creating public links for spaces is no longer possible?! Because the UI currently doesn't reflect that.

Yes, public link for project space disabled. owncloud/ocis#6278 (comment)

This PR will return e2e to ocis

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get the pipeline running, but we might need to re-add the steps later again. I think it was a misunderstanding and creating links for project spaces should still be possible in the future.

@ScharfViktor
Copy link
Contributor Author

Approving to get the pipeline running, but we might need to re-add the steps later again. I think it was a misunderstanding and creating links for project spaces should still be possible in the future.

Yes, sure. When or if we are able to create a link I will return deleted tests

@ScharfViktor ScharfViktor merged commit caa4875 into stable-7.0 May 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the deleteCreatingLinkToProjectSpace branch May 12, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants