Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Fix test expectations #6271

Merged
merged 5 commits into from
May 11, 2023

Conversation

aduffeck
Copy link
Contributor

Fix tests to match the changed behavior in reva regarding sharing of space roots.

/cc @micbar

@update-docs
Copy link

update-docs bot commented May 10, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented May 10, 2023

E2E tests failed: https://drone.owncloud.com/owncloud/ocis/22298/89/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/22298/tracing/public-link-for-space-alice-2023-5-10-08-52-51.zip

@aduffeck aduffeck force-pushed the fix-test-expectations branch from a9ae986 to b614eb6 Compare May 10, 2023 09:45
@phil-davis
Copy link
Contributor

@aduffeck it would be good to get this passing and merged ASAP.
The corresponding reva edge PR cs3org/reva#3849 has changed the ocis branch for API tests to:
APITESTS_BRANCH=fix-test-expectations

When merging this PR, we should (somehow) try to not have the PR branch deleted.

Anyway, if it does go away, we can quickly sort out cs3org/reva#3872 and put back the APITESTS_BRANCH etc settings.

@aduffeck aduffeck force-pushed the fix-test-expectations branch from 7f1e03f to 6c8f9df Compare May 10, 2023 18:52
@aduffeck aduffeck changed the title Fix test expectations [full-ci] Fix test expectations May 10, 2023
@aduffeck aduffeck force-pushed the fix-test-expectations branch from 6c8f9df to 9ca0d99 Compare May 10, 2023 19:59
The expected behavior needs to be discussed.
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants